Scheduled transitions Views field plugins do not handle missing host entities

Addressing part 1 of the proposed resolution.

Upon further inspection it looks like we already have handling for deleted entities in \Drupal\scheduled_transitions\ScheduledTransitionsEntityHooks::entityDelete, we just managed to get ourselves some dangling references to deleted entities by manipulating the db directly. Still, it would be prudent to protect against this.

Can we add handling for the other two sibling Views field plugins

The last submitted patch, 5: 3367794-5.patch, failed testing. View results →

So I opened a whole new issue and MR like an idiot ...

This fix also allows the views field handlers to be used more generically beyond the views supplied by this module - ie in a revisions view where most revisions may not have any scheduled transitions. Very useful, thanks.

Ah, no. It's not just the entity that may be missing, it's also the transition. Guarding against a null transition allows more generic use of the field handlers.

Should we:

A - leave this issue as-is and reopen 🐛 Fatal error: Views field handlers should check transition is not null Needs work to address more generic use, or
B - widen the scope of this issue slightly to handle it here?

Reopening 🐛 Fatal error: Views field handlers should check transition is not null Needs work .

Think this can be RTBC.

Thanks for this, adding this patch to our build. Seems like the right thing to do.