- Issue created by @ruslan piskarov
- last update
over 1 year ago Composer require failure - @ruslan-piskarov opened merge request.
- Status changed to Needs review
over 1 year ago 9:19am 19 June 2023 - last update
over 1 year ago Composer require failure - last update
about 1 year ago 4 pass, 4 fail - π«π·France dydave
Hi Ruslan (@Ruslan Piskarov),
Thank you very much for raising this issue and for contributing a patch, it's greatly appreciated.
Just a quick comment to mention this ticket seems to be related to β¨ New fields added to the menu cannot be exported Needs review where a more generic approach is suggested for supporting in
structure_sync
import/export of any additional data added by other modules, whether contrib or custom, to Menu Link content items.Since Layout Builder isn't really a required core module and
structure_sync
doesn't really require it, there would be many cases where this config key wouldn't necessarily have any use, thus making this patch and config key'layout_builder__layout'
a bit unnecessary/useless.
Therefore, we could perhaps suggest implementing this feature in an additional sub-module, with a depency ondrupal:layout_builder
, with implementations of the hooks added in the patch from the related issue with an example of a custom implementation formenu_link_attributes
at #2980893-13: New fields added to the menu cannot be exported β .However, this would certainly depend on the way maintainers choose the module should evolve, reviews/feedback on adding additional hooks ( #2980893 β¨ New fields added to the menu cannot be exported Needs review ), before really being able to take this feature any further.
Otherwise, in terms of code, it could be something like adding sub-module
structure_sync:structure_sync_layout_builder
which could store implementations of added hooks to import/export the necessary config key'layout_builder__layout'
(instructure_sync_layout_builder.module
) and perhaps a config schema file with its type definition for thestructure_sync.data
config validation.Not sure if this alternative solution would make sense to you, but in any case, we would greatly appreciate if you could please try testing the suggested patch (!MR20), give us your reviews and opinions on the approach taken in this related ticket β¨ New fields added to the menu cannot be exported Needs review .
Feel free to let us know at any point if you have any questions or concerns on any aspects of that patch, this reply or the ticket in general, we would surely be very happy to help.
Thanks again very much for all your code contributions and in advance for your feedback.