- Issue created by @spokje
- 🇳🇱Netherlands spokje
Let's first proof that running
\Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testViewMode()
produces both random test failures.Here's a patch that runs only
\Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testViewMode()
500 times.
Let's test that patch enough times to get a feeling on what the failure rate for both of them is. - last update
over 1 year ago CI aborted - last update
over 1 year ago CI aborted - last update
over 1 year ago CI aborted - last update
over 1 year ago CI aborted - last update
over 1 year ago CI aborted - last update
over 1 year ago CI aborted - 🇳🇱Netherlands spokje
Let's first proof that running
\Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testViewMode()
and\Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testViewMode()
alone produces both random test failures.Here's a patch that runs only
\Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testViewMode()
500 times. - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass, 2 fail - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass, 2 fail - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass, 2 fail - 🇳🇱Netherlands spokje
The normal routine to prove a random failure is fixed is to run the failing patch and the patch with the fix at the same time, whilst the latter has to have ~8000 - 10.000 failure free runs to prove it's credibility.
- last update
over 1 year ago 2 pass, 2 fail - last update
over 1 year ago 2 pass, 2 fail - last update
over 1 year ago 2 pass, 2 fail - last update
over 1 year ago 2 pass, 2 fail - last update
over 1 year ago 2 pass, 2 fail - last update
over 1 year ago 2 pass, 2 fail - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - 🇳🇱Netherlands spokje
12 * 750 = 9000 failure free runs. Also, since
testViewMode
is fed by a dataProvider with 2 cases, the actual method is run twice in each run.Here's the actual patch.
- last update
over 1 year ago 29,499 pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:51am 18 June 2023 - Status changed to RTBC
over 1 year ago 4:27pm 18 June 2023 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked back through to 9.5.x, thanks!
- Status changed to Fixed
over 1 year ago 12:59pm 19 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.