[2.0.x] Simple XML sitemap Page Manager

Created on 16 June 2023, over 1 year ago
Updated 22 July 2023, over 1 year ago

This module will integrate Simple Sitemap with the Panels modules, with this module the user will be able to index a specific Panel page on the sitemap and also manage the pages entities on the sitemap inclusion configuration.

Project link

https://www.drupal.org/project/simple_sitemap_page_manager

📌 Task
Status

Closed: won't fix

Component

module

Created by

🇧🇷Brazil murilohp

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @murilohp
  • 🇮🇳India shashank5563 New Delhi

    Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

    Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

    To reviewers: Please read How to review security advisory coverage applications , What to cover in an application review , and Drupal.org security advisory coverage application workflow .

    While this application is open, only the user who opened the application can make commits to the project used for the application.

    Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

  • Status changed to Needs work over 1 year ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    For these applications, we need a project where, in at least a branch, most (if not all the commits) have been done from the user who creates the application. In this case, I can only see a commit where your username appears. The other commits seems done from the other maintainers/co-maintainers.

    To make it clear: These applications are not for changing a project status, but to give a new Drupal.org role to the user who applies (not to all the maintainers/co-maintainers).
    We do not evaluate the collective effort in making the project secure, following the coding standards, and correctly using the Drupal API done from all the maintainers/co-maintainers. We evaluate what a single maintainer, the one who created the application, knows about those topics. That becomes a difficult, where there are commits from different users.

    This application can continue with a different project.

  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    Verify the email used by Git is the same email associated to your account on https://www.drupal.org/user/3650571/edit . Differently, the commits you do are not associated with your account.

  • 🇧🇷Brazil murilohp

    Thank you for your input here @apaderno!

    For these applications, we need a project where, in at least a branch, most (if not all the commits) have been done from the user who creates the application. In this case, I can only see a commit where your username appears.

    Oh I thought I would be able to apply after fixing the issues, my bad here.

    Verify the email used by Git is the same email associated to your account on https://www.drupal.org/user/3650571/edit .

    And thanks for pointing this, I haven't realized I was commiting using other e-mail
    I think we can close this one as won't fix, since it doesn't make sense to apply for this role right now, I hope to get this in the future but not using this module, anyway, sorry for the noise here.

  • Status changed to Closed: won't fix over 1 year ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    I am closing this application as per comment #6.
    @murilohp Feel free to create a new application when you are ready.

Production build 0.71.5 2024