Remove the commented out code in Resume.theme

Created on 16 June 2023, over 1 year ago
Updated 19 June 2023, over 1 year ago

Problem/Motivation

In the Resume.theme file, there is the following commented out code that needs to be removed. It seems to just provide example values which are not much helpful to understand the code of that theme hook.

Steps to reproduce

Need to remove it as it is unnecessarily increasing the code.

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇮🇳India Prachi6824

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Prachi6824
  • 🇮🇳India Prachi6824

    Hello,

    I have created a patch to resolve the issue.
    Please Review and apply it.

  • Assigned to Prachi6824
  • Status changed to Needs review over 1 year ago
  • Status changed to Needs work over 1 year ago
  • 🇵🇭Philippines clarkssquared

    Hi prachi6824

    I applied your patch #2 to my local with Drupal 9.5.9 and I noticed that the patch fails to apply.

    Please look at the screenshot attach for your reference

    For convenience, below is the output I saw in my terminal as I apply your patch

    portfollio_theme git:(1.0.x) curl https://www.drupal.org/files/issues/2023-06-16/remove-the-commented-code... | git apply -v
    % Total % Received % Xferd Average Speed Time Time Time Current
    Dload Upload Total Spent Left Speed
    100 595 100 595 0 0 2268 0 --:--:-- --:--:-- --:--:-- 2361
    Checking patch Resume.theme...
    error: while searching for:
    */
    function Resume_preprocess_page(array &$variables) {
    $config = \Drupal::config('system.site');
    // $variables['site_name'] = $config->get('name');
    // $variables['site_slogan'] = $config->get('slogan');
    $variables['facebook_url'] = theme_get_setting('facebook_url', 'Resume');
    $variables['twitter_url'] = theme_get_setting('twitter_url', 'Resume');
    $variables['instagram_url'] = theme_get_setting('instagram_url', 'Resume');

    error: patch failed: Resume.theme:6
    error: Resume.theme: patch does not apply

    Thanks

  • 🇮🇳India Prachi6824

    Hello, @clarkssquared thanks for reviewing my patch.
    I have tested my patch again and it is successfully applied at my end .
    I have created the patch for Drupal 10.0.0.
    If you review the patch with this version it will work definitely.
    For further details please checkout the screenshot below.

Production build 0.71.5 2024