- Issue created by @jvogt
- Assigned to Vinayak.Ambig
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:18am 22 June 2023 - 🇮🇳India Vinayak.Ambig
I have fixed the margin issue on small screen.
Before
After
- 🇮🇳India Preeti.chawla
HI @jvogt I have installed Environment Indicator module as mentioned, I have verified the vertical toolbar menus with above Patch#3, it working fine.
- Status changed to RTBC
over 1 year ago 9:20am 17 July 2023 - Status changed to Needs work
over 1 year ago 11:19pm 9 August 2023 - 🇺🇸United States devkinetic
The correct solution would be to actually remove the negative margin altogether. It's no longer needed in more recent versions of Gin. See #3336512-6: Gin Compatibility: Account for "open" vertical toolbar → for details.
I have provided a patch that simply removes the rules altogether.
- Status changed to Needs review
over 1 year ago 11:19pm 9 August 2023 - 🇺🇸United States devkinetic
Updated the patch in sync with the latest changes in 🐛 Gin Compatibility: Account for "open" vertical toolbar Closed: outdated . This patch and the MR on that issue differ in that this one removes the css , but both take into account the js update.
- @devkinetic opened merge request.
- 🇺🇸United States DamienMcKenna NH, USA
FYI there's another issue where similar changes are being worked on: ✨ Improve visibility when using Gin vertical and modern horizontal toolbars Needs work
- Status changed to RTBC
12 months ago 7:11pm 22 November 2023 - 🇺🇸United States jvogt Seattle, WA
Confirmed that patch #8 works on 4.0.17 on Drupal 10.1.6 with php 8.2. Thanks for the patch!
- Status changed to Closed: duplicate
10 months ago 8:33pm 31 January 2024 - 🇺🇸United States devkinetic
I just tested my previous patch against 4.0.17, which no longer works. Upon inspection, it seems to have been resolved by 🐛 Fix GIN Admin Toolbar Style: Secondary toolbar is overlapped by the 3px of the indicators border-top Fixed which I think this item is now a duplicate of and can be closed.