- Issue created by @paucala
- Status changed to Needs review
about 1 year ago 1:20pm 15 June 2023 - First commit to issue fork.
- Status changed to Fixed
3 months ago 12:40pm 11 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.
Running sonarqube we found this issue on ln 747of BetterExposedFilters.php: Make sure that the referenced value variable is unset after the loop.
Why is this a problem?
When a reference is used in a foreach loop instead of using a simple variable, the reference remains assigned and keeps its "value" which is a reference, even after the foreach execution. Most of the time, this is not what the developer is expecting and the reference may be used wrongly in the rest of the code. For this reason, it is recommended to always unset a reference that is used in a foreach to avoid any unexpected side effects.
The proposed solution is remove the reference from de variable
Automatically closed - issue fixed for 2 weeks with no activity.