- Issue created by @mortona2k
- 🇺🇸United States mortona2k Seattle
I ran rector and phpstan, but still had some uncaught issues.
Rector adjusted the use statement in recurring_events.install.
Queries in the list builders are updated to use accessCheck(TRUE). Specifying true/false is now required for entity queries.
Includes fix for event subscriber function (#3366907).
PHPStan didn't catch the query access check issue, but reports a bunch of other things I haven't touched yet.
- @mortona2k opened merge request.
- 🇮🇳India omkar_yewale Mumbai
Also, I'm experiencing a few errors with Drupal 10.
PHP Fatal error: Declaration of Drupal\recurring_events\EventSubscriber\RecurringEventsAdminRouteSubscriber::getSubscribedEvents() must be compatible with Drupal\Core\Routing\RouteSubscriberBase::getSubscribedEvents(): array in /var/www/html/web/modules/contrib/recurring_events/src/EventSubscriber/RecurringEventsAdminRouteSubscriber.php on line 72
Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck().
MR changes have fixed the first error.
and query access check must also be checked here:
/modules/recurring_events_registration/src/RegistrantListBuilder.php
on line 155.keeping this ticket open so that if anyone finds any new issues with Drupal 10 they can add them here.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 11:59am 15 June 2023 - Status changed to RTBC
about 1 year ago 12:02pm 15 June 2023 -
sakthi_dev →
committed aa919880 on 2.0.x
Issue#3366910: Resolve getSubscribedEvents function issue.
-
sakthi_dev →
committed aa919880 on 2.0.x
-
sakthi_dev →
committed 6ce4b85c on 2.0.x
Issue#3366910: Resolve entityQuery issue.
-
sakthi_dev →
committed 6ce4b85c on 2.0.x
- Status changed to Fixed
about 1 year ago 4:06pm 15 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
11 months ago 8:12pm 24 July 2023 - 🇺🇸United States froboy Chicago, IL
Adding one more comment to ensure folks receive notification. #3366910-5: Drupal 10 compatibility → by @sakthi_dev introduces numerous errors in the code. 🐛 Remove failing accessCheck() calls Fixed resolves them.