Figure out if notifications are actually sent / required

Created on 14 June 2023, over 1 year ago
Updated 27 June 2023, over 1 year ago

The module's payment gateway plugin extends OffsitePaymentGatewayBase, whose interface by extension implements the SupportsNotificationsInterface. The reason this module uses that vs. onsite is because the gateway only supports full payments, not authorization only transactions that can be captured upon checkout completion.

However, as far as I can tell, Moneris Checkout doesn't actually make use of notifications. The receipt request linked in πŸ“Œ Remove the receipt checkout pane Fixed is used to validate a transaction, and if there are other notifications sent based on transaction updates at the gateway, those would ostensibly be handled by the Commerce Moneris module itself.

The gateway plugin appears to have a half-implemented onNotify() function. If we don't need it, let's just remove it, and the base implementation (an empty function) should suffice.

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States rszrama

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024