Allow reverting block content with "administer block content" permission

Should be a simple fix but will need test coverage.

Removing credit from sakthi_dev as there was no code to the commit.

Added a test case to the MR.

Left a minor comment, but now that every operation has this orIf, it feels like we could optimise it a bit more before the match. However, would we need to check for all known operations? Or just allow everything if they have the administer permissions (like media, node)

The only tricky part with BlockContent is all the cache dep dancing at the bottom.

Think worth giving a shot!

Left a comment in the MR. I think the tests were incorrect and left behind from when the block library was under blocks and we didn't have separate permissions. I updated the test permissions to use the block_content permission instead. Also moved the check up as suggested by @acbramley in #7. The switch won't run if the accessResult comes back true.

Adding related issue, these 2 will touch the same code.

Changes looking good! Thanks @smustgrave

Committed to 11.x and 10.2.x

Doesn't apply to 10.1.x, needs a reroll

larowlan → closed merge request !4981

This is not a straightforward backport, 10.1.x didn't get the backport of 🐛 Revert and Delete actions should not be available for the current revision Fixed which means tests fail here because admin permission is bypassing the $forbidIfNotDefaultAndLatest check.

Not sure on the best way to handle that without diverging the branches too much.

Here's a WIP patch anyway.

Reroll seems good.

Please see #16

At this point, let's make this 10.2.x only.

Automatically closed - issue fixed for 2 weeks with no activity.