Release of CAPTCHA 2.0 will break compatibility with most D10 compatible submodules

Created on 14 June 2023, over 1 year ago

Problem/Motivation

So first, I have to apologize. I committed a breaking change in 2.x through #3316486: [2.x] Code review, cleanup and tests → for all submodules, WITHOUT a proper review!!

Through https://git.drupalcode.org/project/captcha/-/commit/5b78c8d the "CaptchaConstants" class was implemented, as declaring constants in the module file got deprecated. This lead to submodules needing to use this "CaptchaConstants" class instead of the old constants. Unfortunately, I missed my mark on declaring these old constants deprecated.

The following submodules might be affected (if they use any CAPTCHA constants):

Steps to reproduce

Proposed resolution

Check the listed modules on old CAPTCHA constants
Remove the CAPTCHA constants class
Readd the old global CAPTCHA constants
Readjust the constant's usage in https://www.drupal.org/project/riddler →
Mark the old constants deprecated and "removed" in 2.1.x

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Closed: works as designed

Version

2.0

Component

Code

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @Grevil
Comment over 1 year ago →
🇩🇪Germany Grevil
OK, we are actually quite lucky. None of the listed submodules use any CAPTCHA constants. The only one is riddler. And there we have the D10 specific release, where we already use the correct constants.

So if @Anybody agrees, we can simply close this issue as "works as designed"?
Status changed to Closed: works as designed over 1 year ago8:47am 14 June 2023
Comment over 1 year ago →
🇩🇪Germany Anybody Porta Westfalica
Thanks for the heads-up @Grevil and checking the submodules. I agree this is fine for 2.x! Let's close it works as designed.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024