The menu configuration cache is cleared on each save of any menu_link_content entity

Created on 9 June 2023, almost 2 years ago

Updated 21 June 2023, almost 2 years ago

Problem/Motivation

On saving any "menu_link_content" entity, I see that the cache of the configuration of the related menu is always cleared, but the configuration should have no changes by this operation.

After saving a menu item in "footer" menu, using Drupal Admin UI, the first call happens with these cache tags:
- "menu_link_content_list"
- "menu_link_content_list:footer"
- "4xx-response"

And then, the second call - with clearing the menu config:
- "config:system.menu.footer"

Steps to reproduce

1. Get a clean Drupal installation.

2. Set a breakpoint to function CacheTagsInvalidator::invalidateTags()

3. Open the "Footer" menu: /admin/structure/menu/manage/footer, click on the "Add link" button.

4. Add a new item with any name and link, and press "Save".
See that the "config:system.menu.footer" tag is invalidated.

5. Edit the created menu item and save it again.
See that the "config:system.menu.footer" tag is invalidated again.

Proposed resolution

The menu configuration has no stored information, related to its items, here is an example:

uuid: 41570d25-8790-4c10-9f19-e5b986b0f31e
langcode: en
status: true
dependencies: {  }
_core:
  default_config_hash: 7yrlW5z9zdg2eBucB2GPqXKSMQfH9lSRSO4DbWF7AFc
id: footer
label: Footer
description: 'Site information links'
locked: true

So, from my point of view, clearing the configuration cache is unnecessary for this case.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Needs work

Version

10.1 ✨

Component

Menu system →

Last updated 1 day ago

Maintained by
🇩🇪Germany @dawehner
🇺🇸United States @pwolanin

Created by

🇦🇲Armenia murz Yerevan, Armenia

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @murz
Comment almost 2 years ago →
🇦🇲Armenia murz Yerevan, Armenia
Comment almost 2 years ago →
🇮🇳India sumit-k
I have successfully replicated the scenario, and it appears that removing Menu config entities makes sense in this context. It seems that this issue has already been reported in the ticket https://www.drupal.org/project/drupal/issues/2488918 → . In Drupal 10, this behavior is considered to be working as designed. It seems that this task will be addressed in the upcoming Drupal version 11.
Status changed to Needs review almost 2 years ago10:35am 19 June 2023
Comment almost 2 years ago →
🇮🇳India sumit-k
Status changed to Needs work almost 2 years ago1:36pm 21 June 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
There appears to be no patch to review. But would bring up #contribute if you are asking if this is by design.

Maybe a test-only patch to show the issue could also help.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024