- Issue created by @JeroenT
- @jeroent opened merge request.
- Status changed to Needs review
over 1 year ago 11:58am 9 June 2023 - Status changed to Needs work
over 1 year ago 4:24pm 9 June 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Will need a rebase.
This is a major feature which was still somewhere on my roadmap to tackle. Thanks for your work Jeroen! Will try to test this next week.
- Status changed to Needs review
over 1 year ago 6:55am 12 June 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Warning: Undefined array key "enabled" in Drupal\keycloak\Plugin\OpenIDConnectClient\Keycloak->applyRoleRules() (line 758 of /var/www/html/web/modules/contrib/keycloak/src/Plugin/OpenIDConnectClient/Keycloak.php)
Noticed the following in the logs which should be fixed as well.
- Status changed to Needs work
over 1 year ago 7:26am 15 June 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
The Add and Remove button on the role mappings is still breaking the AJAX callback with the following errors:
Warning: Trying to access array offset on value of type null in Drupal\keycloak\Plugin\OpenIDConnectClient\Keycloak->rulesAjaxCallback() (line 530 of /var/www/html/web/modules/contrib/keycloak/src/Plugin/OpenIDConnectClient/Keycloak.php)
Message TypeError: Drupal\Core\Render\MainContent\AjaxRenderer::renderResponse(): Argument #1 ($main_content) must be of type array, null given, called in /var/www/html/web/core/lib/Drupal/Core/Form/FormAjaxResponseBuilder.php on line 89 in Drupal\Core\Render\MainContent\AjaxRenderer->renderResponse() (line 49 of /var/www/html/web/core/lib/Drupal/Core/Render/MainContent/AjaxRenderer.php)
- Status changed to Needs review
over 1 year ago 8:04am 15 June 2023 - Status changed to RTBC
over 1 year ago 8:07am 15 June 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
One thing that could improved is an explanation what the "Pattern" field does. I had to look into the code to figure out that the group pattern needed to be without the slash in front of it. So not
/groupname
butgroupname
. I guess a few examples with more complex use cases could help.I'll create a small follow up for that. I tested this and it works great!
-
BramDriesen →
committed 15cf49f3 on 2.2.x authored by
JeroenT →
Issue #3365863 by JeroenT, BramDriesen: [openid_connect 3.x] Support...
-
BramDriesen →
committed 15cf49f3 on 2.2.x authored by
JeroenT →
- Status changed to Fixed
over 1 year ago 8:13am 15 June 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Created follow up: 📌 Explain the groups pattern field + documentation Active
Automatically closed - issue fixed for 2 weeks with no activity.