Read more link always displayed in some settings

@bioschaf,
I am using these settings given in screenshot. But it is working as expected.
Can you give the proper steps to reproduce the issue?

I am using the same settings, I selected
[x] Display More link?
and
[x] Display More link only when content is trimmed?

I don't think it is a problem with the settings of this module an how they work.

As I wrote the "SmartTrimFormatter.php" compares two variables ($output and $original_output) to determine if the "More"-Link should be added or not. In my case (whatever the reason may be) $original_output contains a newline character at the end, which is stripped by this module's function "truncateChars" in TruncateHTML.php, even if the content itself is not shortened.

@bioschaf,

Thanks for your report and efforts on this issue.

I have modified one of the test nodes in our existing SmartTrimFunctionalTest.php with a trailing "\r\n " - without any fix testMoreLinkOnlyWhenContentIsTrimmed() failed (good news!)

I then removed the trim($html) bits from the TruncateHTML service methods and moved them to the formatter. This ensures that both the $output and $original_output are trimmed equally. With this fix, all tests pass.

MR created and assigned to @markie for review.

-mike

D9 test currently failing.

1) Drupal\Tests\smart_trim\Unit\TruncateHTMLTest::testRemoveHtmlComments
ReflectionException: Trying to invoke protected method Drupal\smart_trim\TruncateHTML::removeHtmlComments() from scope ReflectionMethod
/builds/project/smart_trim/tests/src/Unit/TruncateHTMLTest.php:190
/builds/project/smart_trim/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
/builds/project/smart_trim/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/builds/project/smart_trim/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/builds/project/smart_trim/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/builds/project/smart_trim/vendor/phpunit/phpunit/src/TextUI/Command.php:144
/builds/project/smart_trim/vendor/phpunit/phpunit/src/TextUI/Command.php:97
phpvfscomposer:///builds/project/smart_trim/vendor/phpunit/phpunit/phpunit:106

See https://git.drupalcode.org/project/smart_trim/-/jobs/58193 for full info.

-mike

Turns out this was an easy fix - I had written the test for PHP 8.1+, which is why it failed the D9 test. MR updated.

-mike

All tests passing.

Added Drupal Dev Days tag.

Merged. Thanks for all the good work

Automatically closed - issue fixed for 2 weeks with no activity.