- Issue created by @bbrala
- Merge request !10Draft: Issue #3364713 by lauriii, bnjmnm, andy-blum, Dave Reid, cosmicdreams: Claro:... β (Merged) created by bbrala
- First commit to issue fork.
- e0ipso Can Picafort
I uploaded a proposal in https://git.drupalcode.org/issue/drupal-3352256/-/merge_requests/16
- Status changed to Needs review
about 1 year ago 11:23am 1 December 2023 - e0ipso Can Picafort
In order to remove the
sdc_library_info_build
I had to makecore/
the owner of the libraries. This simplifies the way we compute the paths from the library owner to the asset location. However there was no ideal place to compute the component libraries. I settled withcore/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php
as it already contained special casing for the'core'
extension. Please advice if there is a better solution.I added some commentary to the feature MR https://git.drupalcode.org/issue/drupal-3352256/-/merge_requests/16
- Status changed to RTBC
about 1 year ago 2:41pm 4 December 2023 - πΊπΈUnited States smustgrave
This may be one of those tickets it would be easier to see the goal when all steps are complete.
For the removal of the help hook though, can a follow up be to add a help_topic file to maybe help or system modules?
- e0ipso Can Picafort
Thanks for the review @smustgrave! I am holding the merge until @plopesc confirms my responses satisfy his questions in the MR. I don't want to wait too much though, now that we have momentum on this!
- Status changed to Fixed
about 1 year ago 2:08pm 5 December 2023 - e0ipso Can Picafort
Merged after getting slack approval from @plopesc.
@smustgrave I looked into moving hook help into a topic, but I couldn't find a good example of where to put it. AFAICT None other framework component / features have help topics. I think the online documentation is enough. The hook_help wasn't all that useful, to be honest, it was a requirement to pass the module generic test (which is removed now).
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
7 months ago 5:31pm 18 June 2024