- Issue created by @bbrala
- Merge request !6Draft: Issue #3364713 by lauriii, bnjmnm, andy-blum, Dave Reid, cosmicdreams: Claro:... β (Merged) created by bbrala
- First commit to issue fork.
- Merge request !14Move SDC Element\ComponentElement to Core namespace β (Merged) created by plopesc
- Status changed to Needs review
7 months ago 3:19pm 30 November 2023 - πͺπΈSpain plopesc Valladolid
Created MR https://git.drupalcode.org/issue/drupal-3352256/-/merge_requests/14
ComponentElement class moved and tests are passing properly.
However, I'm not sure about how to deal with Component*Test classes. My first thought was to move them to Drupal\Tests\Core\Render\Element namespace. However I'm not sure whether all those tests should belong to that namespace. Also module tests are divided into Kernel/Functional/ etc namespaces, while the core namespace mentioned above doesn't. Moving tests there would imply to rename test classes or create the test type specific namespaces.
Any thought or guidance here would be much appreciated.
Thank you!
- Status changed to RTBC
7 months ago 2:39pm 1 December 2023 - πΊπΈUnited States smustgrave
Not sure this issue is suppose to cover the test moves, but if not going to mark.
As far as your question not sure I understand. But I think the tests will have to be separate if that's what you're asking.
So unit tests can go under Drupal\Tests\Core\Render\Element
Kernel tests under Drupal\KernelTests\Core\Render\Element;Least that's how I've understood the core test folder structure.
- Status changed to Fixed
7 months ago 9:16pm 4 December 2023 - e0ipso Can Picafort
Merged!
I agree that the test placement presents unique challenges. Let's move this discussion to a test specific issue.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
8 days ago 5:31pm 18 June 2024