- Issue created by @bbrala
- Merge request !4Issue #3365686: Move SDC ComponentNegotiator to Core namespace β (Merged) created by bbrala
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 4:12pm 16 November 2023 - πͺπΈSpain plopesc Valladolid
- Status changed to RTBC
about 1 year ago 2:03pm 22 November 2023 - πΊπΈUnited States smustgrave
Without the tests I can't tell if it broke anything, but purely looking at the move seems fine.
- e0ipso Can Picafort
This looks good to me. The only remaining bit is to make sure we duplicate the Enum for BC.
- Status changed to Needs work
about 1 year ago 8:39pm 23 November 2023 - Status changed to Needs review
about 1 year ago 6:47am 24 November 2023 - πͺπΈSpain plopesc Valladolid
Thank you for your review!
Enum has been duplicated, let's go for a second round of review.
- Status changed to RTBC
about 1 year ago 2:41pm 24 November 2023 - πΊπΈUnited States smustgrave
Remarking as seems feedback from maintainer has been addressed.
- e0ipso Can Picafort
Looks good! Let's bring this to the parent branch. Thanks everyone. I will credit the missing participants in the parent ticket.
- Status changed to Fixed
about 1 year ago 3:55pm 24 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
7 months ago 5:32pm 18 June 2024