- Issue created by @Grimreaper
- Merge request !22Issue #3365674: Wrong formatter selected during the update → (Merged) created by Grimreaper
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:40pm 8 June 2023 - 🇫🇷France duaelfr Montpellier, France
@Grimreaper your change is quite opinionated. Could you explain a bit more why you think this is a good one?
Based on the way 1.x branch was working, I thought it was better to upgrade using "each" formatter for multiple fields but I may be mistaken.Bumping to major as it's impacting upgrade path.
- 🇫🇷France Grimreaper France 🇫🇷
Hi @DuaelFr,
I understand that you found that very opinionated, and I totally agree with you, so maybe it will only be an highlight of potential problems. Currently on the first website I tried to update, I only had 3 config to update, no layout builder override, so no problem to fix config manually afterward.
My thinking (and my usage) of the "Rendered entity, wrapped in a pattern" (pattern_wrapper_entity_reference_formatter) formatter is for cases of patterns in patterns. I think with a concrete example it will be better to explain.
Patterns:
- carousel / carousel item
- accordion / accordion item
- gris row / card (or whatever)One entity type, mainly node or block content has a multivalued entity reference field (standard or paragraphs) and use the carousel pattern to wrap the referenced entities. The referenced entities in the selected view mode use the carousel item pattern.
Is it more clear for you?
- Assigned to duaelfr
- 🇫🇷France pdureau Paris
Hi Duaelfr, I take care of 1.0.x reviews, and I assign the 2.0.x review to you.
-
grimreaper →
authored c77f09e5 on 2.x
Issue #3365674: Wrong formatter selected during the update
-
grimreaper →
authored c77f09e5 on 2.x
- 🇫🇷France duaelfr Montpellier, France
@Grimreaper you were right! Thank you!
Automatically closed - issue fixed for 2 weeks with no activity.