- Issue created by @andypost
- @andypost opened merge request.
- Status changed to Needs review
over 1 year ago 12:22am 8 June 2023 - π«π·France andypost
Used to build fine locally
- upgraded APCu to latest https://github.com/krakjoe/apcu/releases/tag/v5.1.22 vs 8.2 using 8.3.5
- latest drush8 https://github.com/drush-ops/drush/releases/tag/8.4.12 vs 8.2 using 5.1.20Needs to fix m4 file generators!
3 source will vary while not stable so I hardcoded to build locally
# PHP Version -ENV PHP_VERSION 8.2.3 -ENV PHP_URL="https://php.net/distributions/php-8.2.0.tar.xz" +ENV PHP_VERSION 8.3.0 +#ENV PHP_URL="https://php.net/distributions/php-8.2.0.tar.xz" +ENV PHP_URL="https://downloads.php.net/~jakub/php-8.3.0alpha1.tar.xz"
After build I was able to use it
root@5f266f15b850:/var/www/html# php -v PHP 8.3.0alpha1 (cli) (built: Jun 7 2023 23:53:28) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.0-dev, Copyright (c) Zend Technologies with Zend OPcache v8.3.0alpha1, Copyright (c), by Zend Technologies root@5f266f15b850:/var/www/html# php -m [PHP Modules] apcu bcmath Core ctype curl date dom exif fileinfo filter ftp gd gettext hash iconv intl json libxml mbstring mysqli mysqlnd openssl pcntl pcre PDO pdo_mysql pdo_pgsql pdo_sqlite Phar posix random readline Reflection session shmop SimpleXML soap sockets SPL sqlite3 standard sysvsem sysvshm tidy tokenizer xml xmlreader xmlwriter xsl Zend OPcache zip zlib [Zend Modules] Zend OPcache
- π«π·France andypost
I was able to install core and drush using sqlite DB,
Also using `--ignore-platform-reqs` for drush becauseroot@5f266f15b850:/var/www/html# composer require drush/drush ^12 ./composer.json has been updated Running composer update drush/drush Loading composer repositories with package information Updating dependencies Your requirements could not be resolved to an installable set of packages. Problem 1 - phpspec/prophecy v1.17.0 requires php ^7.2 || 8.0.* || 8.1.* || 8.2.* -> your php version (8.3.0alpha1) does not satisfy that requirement. - drupal/core-dev 11.x-dev requires phpspec/prophecy-phpunit ^2 -> satisfiable by phpspec/prophecy-phpunit[v2.0.2]. - phpspec/prophecy-phpunit v2.0.2 requires phpspec/prophecy ^1.3 -> satisfiable by phpspec/prophecy[v1.17.0]. - drupal/core-dev is locked to version 11.x-dev and an update of this package was not requested.
- π«π·France andypost
The image size is 1.56GB but it can be minified x3 so each job will download/run less (near 1 minute)
-
hestenet β
committed b4499a68 on production authored by
andypost β
Resolve #3365510 "Php83"
-
hestenet β
committed b4499a68 on production authored by
andypost β
-
hestenet β
committed b4499a68 on dev authored by
andypost β
Resolve #3365510 "Php83"
-
hestenet β
committed b4499a68 on dev authored by
andypost β
- πΊπΈUnited States hestenet Portland, OR πΊπΈ
Merged and waiting to confirm it works, with these 2 queued jobs:
Queueing: 8.3 and MySql8 on 11.x: https://www.drupal.org/pift-ci-job/2691057 β
Queuing: 8.3 and MySQL 8 on 10.1.x: https://www.drupal.org/pift-ci-job/2691058 β - π«π·France andypost
Here's alpha2 tarballs https://downloads.php.net/~eric/
- @andypost opened merge request.
-
hestenet β
committed ea7902a3 on production authored by
andypost β
Resolve #3365510 "83 alpha2"
-
hestenet β
committed ea7902a3 on production authored by
andypost β
-
hestenet β
committed ea7902a3 on dev authored by
andypost β
Resolve #3365510 "83 alpha2"
-
hestenet β
committed ea7902a3 on dev authored by
andypost β
- @andypost opened merge request.
- π«π·France andypost
@hestenet There's MR for alpha 3 https://git.drupalcode.org/project/drupalci_environments/-/merge_requests/8
- πΊπΈUnited States bradjones1 Digital Nomad Life
Per conversation at https://drupal.slack.com/archives/C1BMUQ9U6/p1689006958360499?thread_ts=... I think we would like to ensure this includes SQLite >= 3.38 to ensure it has support for pointer query syntax on JSON data storage.
- @andypost opened merge request.
- π«π·France andypost
Beta 1 is out but API still not yet frozen.
As I see all deprecation RFCs are commited so it's time to fix'em
@hestenet https://git.drupalcode.org/project/drupalci_environments/-/merge_requests/9
- πΊπΈUnited States hestenet Portland, OR πΊπΈ
Images were updated to 8.3-beta1:
- 11.x: https://www.drupal.org/pift-ci-job/2719854 β
- 10.1.x-dev: https://www.drupal.org/pift-ci-job/2719855 β
Still looking at how best to update the sqlite version, as we don't currently define explicitly in the same way.
- π«π·France andypost
There's idea about sqlite - we can upgrade PHP 8.3 image to use current stable debian https://packages.debian.org/bookworm/sqlite3
It has
3.40.1
and using it as test base brings CI inline with Debian derivatives - @andypost opened merge request.
- π«π·France andypost
It is blocked on build infra upgrade to allow build the images based on bookworm (apt keys changed)
- @andypost opened merge request.
- π«π·France andypost
- @andypost opened merge request.
- Assigned to hestenet
- π«π·France andypost
Created https://git.drupalcode.org/project/drupalci_environments/-/merge_request... which builds image but can't login to push (needs credentials)
Moreover it could use follow-ups to improve
-
Warning: apt-key is deprecated
- https://github.com/nodesource/distributions#debmanual
- https://docs.docker.com/build/building/multi-stage/ to slim down result image (option--squash
even increases size) - π«π·France andypost
The issue has a patch which should pass tests for new image π Fix deprecated assert_options() function usage for PHP 8.3 Needs review
- πΊπΈUnited States hestenet Portland, OR πΊπΈ
8.3 image is deployed, and the DCI labels have been updated.
It's built with the new GitlabCI based process and should be running on more modern debian thanks to @andypost - so hopefully this also addresses the sqlite version issue from #15
- @andypost opened merge request.
- π«π·France andypost
User cherry-pick to move commit to production branch https://git.drupalcode.org/project/drupalci_environments/-/merge_request...
Updated php:8.3 image deployed https://git.drupalcode.org/project/drupalci_environments/-/jobs/72220
Only label updates are a question of remaining automation
- @andypost opened merge request.
- π«π·France andypost
Merged RC2 to dev for testing https://git.drupalcode.org/project/drupalci_environments/-/commit/a633d7...
Gonna cherry-pick the commit when release will be announced
- Issue was unassigned.
- π«π·France andypost
Further split onto cli/apache/yarn images still promissing after sqlite image landed
- Status changed to Fixed
9 months ago 10:00pm 22 December 2023 - π«π·France andypost
Pushed 8.3.1 upgrade so consider it fixed, see you in optimization issue #3387737: Split PHP image into php(cli/apache) and yarn(node/nightwatch) β
Automatically closed - issue fixed for 2 weeks with no activity.