Convert Olivero's figure component to use single directory components

Issue created by @mherchel
Assigned to javi-er
Comment 12 months ago →
javi-er
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,437 pass
@javi-er opened merge request.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,437 pass
Status changed to Needs review 12 months ago2:29pm 8 June 2023
Comment 12 months ago →
javi-er
This is ready for review, for the "group" on the component yaml I used "Media" but I'm not sure if there is a standardized list of components groups that we should be using.
Status changed to RTBC 12 months ago6:39pm 8 June 2023
Comment 12 months ago →
🇺🇸United States smustgrave
With my limited knowledge of SDC.

I enabled the SDC module and applied the MR.
Adding an image with a caption verified the styling is unchanged and nothing has broke.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,438 pass
Status changed to Needs work 12 months ago1:21am 11 June 2023
Comment 12 months ago →
🇺🇸United States mherchel Gainesville, FL, US
This is looking good! Added some comments
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,445 pass
Status changed to Needs review 12 months ago2:30pm 13 June 2023
Comment 12 months ago →
javi-er
Thanks for the feedback @mherchel ! this is ready for review again.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,445 pass
Status changed to Postponed 12 months ago4:03pm 13 June 2023
Comment 12 months ago →
🇺🇸United States smustgrave
Changes look good! Postponing though until SDC is marked stable and can merged.

Convert Olivero's figure component to use single directory components

Comments & Activities