- Issue created by @bbrala
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 9:25am 6 November 2023 - πͺπΈSpain plopesc Valladolid
MR available at https://git.drupalcode.org/issue/drupal-3352256/-/merge_requests/3
Namespace used for the exceptions is `Drupal\Core\Render\Component\Exception` instead of `Drupal\Them\Exception` in order to respect the already existing class aliases.
- Status changed to Needs work
about 1 year ago 3:32pm 6 November 2023 - πΊπΈUnited States smustgrave
Don't think I can do it but can you open an MR against this issue? I see the branches and the MR link but doesn't appear they are connected? MR didn't have the tests run at least.
- Status changed to Needs review
about 1 year ago 4:15pm 6 November 2023 - πͺπΈSpain plopesc Valladolid
Thank you for your review @smustgrave
This issue is a specific use case, where the MR is not created against the main drupal core origin.
Besides the MR mentioned above, against the META repo (https://git.drupalcode.org/issue/drupal-3352256/-/merge_requests/3), created a new one against this fork, which is not triggering Gitlab CI either(https://git.drupalcode.org/issue/drupal-3365468/-/merge_requests/1)
Already commented this with @e0ipso, who is aware of the situation.
I believe it is OK to leave this issue in NR status.
Thank you!
- πͺπΈSpain fjgarlin
A few things that might help.
- The forks might need rebasing so the.gitlab-ci.yml
files get into the codebase. I don't see them there so this might be the primary reason why they don't run.
- The second thing might be that the MRs need to be against the 11.x origin core branch, not fork to fork MRs. There is the condition of$CI_PROJECT_ROOT_NAMESPACE == "project"
in the workflow file (https://git.drupalcode.org/project/gitlab_templates/-/blob/1.0.x/include...) which might have an impact. - πΊπΈUnited States smustgrave
Could #7 be done? Don't think this can be reviewed without knowing if it breaks existing test coverage.
- e0ipso Can Picafort
@smustgrave proper peer review will be done in the parent ticket. This MR is merging onto the feature branch of the parent. The reason to break things up is to have a place to have coherent discussions about the approach of each of the parts. Also so allow different people to work on different small parts.
Test coverage will be ensured in the step of merging the parent onto 11.x.
- Status changed to RTBC
about 1 year ago 6:54pm 21 November 2023 - πΊπΈUnited States smustgrave
Purely looking at the code the deprecations seems correct. Without the tests can't tell if anything broke, but code wise looks fine.
- Status changed to Fixed
about 1 year ago 1:22pm 30 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
7 months ago 5:32pm 18 June 2024