L10nPackagerFileInterface is left unused

Created on 7 June 2023, over 1 year ago
Updated 13 June 2023, over 1 year ago

Although an L10nPackagerFileInterface interface is defined, it is not used by the l10n_packager_file entity. Provided this interface is relevant (I believe it is), it should be implemented by L10nPackagerFile. We should then use it to type the third argument of L10nPackager::package().

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇫🇷France fmb Perpinyà, Catalonia, EU

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Comments & Activities

  • Issue created by @fmb
  • 🇫🇷France fmb Perpinyà, Catalonia, EU
  • 🇧🇷Brazil elber Brazil

    Hi I need more details I implemented the interface in L10nPackagerFile.php class L10nPackagerFile extends ContentEntityBase implements L10nPackagerFileInterface but I had several errors like this 'Drupal\l10n_packager\Entity\L10nPackagerFile' does not implement methods 'getRelease', 'setRelease', 'getReleaseId', 'setReleaseId', 'getLanguage', 'setLanguage', 'getFile', 'setFile', 'getFileId', 'setFileId', 'getStringCount', 'setStringCount', 'setCheckedTime' Do you want these method be implemented in this class or am I doing something wrong.

  • 🇫🇷France fmb Perpinyà, Catalonia, EU

    Yes, these methods also need to be implemented, sorry about that. Thanks!

  • @elber opened merge request.
  • Status changed to Needs review over 1 year ago
    • FMB committed 79a6fae2 on 3.0.x authored by elber
      Issue #3365352 by elber, FMB: L10nPackagerFileInterface is left unused
      
  • Status changed to Fixed over 1 year ago
  • 🇫🇷France fmb Perpinyà, Catalonia, EU

    Thanks @elber! I had to rework some of it, for instance the part about project IDs, which are not directly related to this entity (it was not your fault, the interface was wrong in the first place).

    Out of curiosity, how did you hear about this issue? During Drupalcon?

  • 🇧🇷Brazil elber Brazil

    Hi I just saw it in the issues queue.

    It was a pleasure to work on it for me!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024