- Issue created by @brianperry
- 🇨🇦Canada mandclu
Can verify that I'm seeing a regression in the new release. For me, even the title doesn't update, and appears to be reloading the whole page instead of live updating just the contents of the h1.
Also, on my site this version doesn't work at all when JS aggregation is on, throwing this error:
An error occurred during the execution of the Ajax response: TypeError: Cannot read properties of null (reading 'src') - @brianperry opened merge request.
- Status changed to Needs review
over 1 year ago 3:44pm 7 June 2023 - 🇺🇸United States brianperry
Opened an MR with what I believe to be a fix.
That aggregation thing has been driving me mad as well. My current belief is that it is a combination of our local environments and aggregation related changes in 10.1. More info here: https://www.drupal.org/project/same_page_preview/issues/3357541#comment-... ✨ Unhide Drupal Core's preview button Fixed But I encourage you to sanity check me on that. I suppose one way to validate this for sure would be to deploy the latest release somewhere (you and I both know some options, lol) and confirm that aggregation works.
- Status changed to RTBC
over 1 year ago 11:17am 8 June 2023 - 🇨🇦Canada mandclu
The MR resolves the regression for me, and with it applied the previous functionality works, even with aggregation on.
- Status changed to Fixed
over 1 year ago 2:00pm 9 June 2023 - 🇺🇸United States brianperry
Merged and rolled a 2.1.1 release https://www.drupal.org/project/same_page_preview/releases/2.1.1 →
Automatically closed - issue fixed for 2 weeks with no activity.