Unhide Drupal Core's preview button

Opened a draft MR with a first pass at this. It works, but only with js not aggregated for some reason. I suspect that this is somehow related to my local environment - will try to figure out what is going on there, but need to set this aside for now.

I'll test this manually today.

Brian this works for me, with css aggregation / caching on. I do get a strange and seemingly unrelated error though. Is this what you're seeing?

@cosmicdreams - I haven't seen the error in your screenshot. When I aggregate JS I see the following error in the browser console:

An error occurred during the execution of the Ajax response: TypeError: Cannot read properties of null (reading 'src')

As a result of this error, when I click on the preview button the panel doesn't expand due to the broken JS.

I've duped this on another machine, so I don't think this was related to my local being hosed. Will take another shot at figuring out what is going on here.

I'm now confident that this is actually related to my local environment and not this module. Examining the aggregated JS I wasn't seeing the changes I expected. I eventually went nuclear and blew away all JS files manually. When the JS was re-built I saw the changes I expected, and the error went away. Doing the same thing for the CSS also resolved the CSS strangeness we have been seeing.

I'm using Lando - in digging around for related Lando issues I found these:

https://github.com/lando/drupal/pull/48
https://github.com/lando/drupal/pull/57

Apparently aggregation changed in some non-trivial ways in 10.1: https://www.drupal.org/node/2888767 →

@cosmicdreams - If you agree with the assessment here I think this one would now be resolved by the 2.1 branch.

Marking as fixed since this has been merged into 2.1.x.

Automatically closed - issue fixed for 2 weeks with no activity.