Add admin route to media library routing

Issue created by @wouter waeytens
Comment about 2 years ago →
🇧🇪Belgium wouter waeytens
Status changed to Needs review about 2 years ago1:06pm 7 June 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
30,338 pass
Comment about 2 years ago →
cilefen
Status changed to RTBC about 2 years ago10:46pm 7 June 2023
Comment about 2 years ago →
🇺🇸United States smustgrave
Simple enough change that didn't cause any issues. Could almost say this is a task too vs a bug but could be wrong.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
30,338 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
30,338 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
30,338 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
30,341 pass
Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
Waiting for branch to pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,341 pass
Comment almost 2 years ago →
🇬🇧United Kingdom longwave UK
The media library is also designed to be used on the front end, not sure it is always considered an admin route? Can you explain a bit further about the issues that are solved by making this change?
Status changed to Postponed: needs info almost 2 years ago1:28pm 22 July 2023
Comment almost 2 years ago →
🇬🇧United Kingdom longwave UK
Comment almost 2 years ago →
🇺🇸United States Chris Matthews
@Wouter Waeytens, by chance would you be able to advise regarding the questions posed in #5 🐛 Add admin route to media library routing Postponed: needs info ?

The media library is also designed to be used on the front end, not sure it is always considered an admin route? Can you explain a bit further about the issues that are solved by making this change?
Comment over 1 year ago →
🇧🇪Belgium wouter waeytens
It should always return the language that the user has set for editing the page. This is not the case it always returns the content language not the admin language.
Comment 22 days ago →
🇦🇺Australia acbramley
Tested this with a Node form and toggling the use_admin_theme setting. When the node edit form is using the admin theme, the media library is also rendered in the admin theme. When the node edit form is using the frontend theme, the media library is rendered with the frontend theme.

Changing the media library route definition (i.e what the patch does) had no effect on this.

Given this change is quite easy to make in a custom project using a route subscriber, should this be closed as won't fix?

Add admin route to media library routing

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities