- Issue created by @arti_parmar
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:05am 7 June 2023 - last update
over 1 year ago Patch Failed to Apply - Assigned to arti_parmar
- last update
over 1 year ago Patch Failed to Apply - 🇮🇳India arti_parmar
I have upload the correct patch
https://www.drupal.org/files/issues/2023-06-07/3365244-3.patch →
Please review. - Issue was unassigned.
- Status changed to Needs work
6 months ago 6:43am 27 June 2024 - 🇮🇳India Vishal Choudhary Dharmshala
There is an issue if I apply your Comment #3 patch file
please check again Screenshot attached.
Thanks. - Status changed to RTBC
6 months ago 8:06am 8 July 2024 - 🇮🇳India chaitanyadessai Goa
@Vishal Choudhary the patch changes have already been released in version 1.0.x therefore no need to apply the patch.
- Status changed to Needs review
6 months ago 8:09am 8 July 2024 - Status changed to Needs work
6 months ago 5:48am 11 July 2024 - 🇮🇳India vinmayiswamy
Hi @chaitanyadessai,
Indeed, the changes have been released in version 1.0.x. But still, the warning wasn't resolved.I verified this in Drupal version 10.2.x. I'm still getting this
Unused variable $i.warning along with other phpcs issues.Below are the phpcs issues from the same file.
$ ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/ckeditor FILE: /Users/vinmayi.nidubrolu/projects/drupal102x/drupal/modules/contrib/ckeditor/tests/src/FunctionalJavascript/BigPipeRegressionTest.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 55 | ERROR | Public method name "BigPipeRegressionTest::testCommentForm_2698811" is not in lowerCamel format 100 | WARNING | Unused variable $i. -------------------------------------------------------------------------------------------------------------------------------------------Moving back to NW.
Thanks!