Claro: Messages can be malformed when JS creates messages and PHP messages already exist

The last submitted patch, 2: 3364713-2.patch, failed testing. View results →

Yea, it's a pretty minimal change here. Looks good.

Closed 🐛 Drupal.messages displays new messages inside any existing messages on the site instead of separating them. Closed: duplicate in favor of this issue. Not sure if/how to transfer credits.

Adding some review screenshots here. One thing I'm seeing is that the JS-created message markup does not match the PHP-generated markup, but I think that's more of an error on the PHP side related to 🐛 Messages should have role=status instead of role=contentinfo Needs work .

+1 to RTBC.

Comment and an easy request. Simple enough that a self RTBC is 100% fine once it is done.

1. +++ b/core/modules/system/tests/modules/olivero_test/olivero_test.module
   similarity index 86%
   copy from core/tests/Drupal/Nightwatch/Tests/Olivero/oliveroDrupalMessageTest.js
   
   copy from core/tests/Drupal/Nightwatch/Tests/Olivero/oliveroDrupalMessageTest.js
   copy to core/tests/Drupal/Nightwatch/Tests/Claro/claroDrupalMessageTest.js
   

   It's worth at least pointing out that these two tests are quite similar, but I think it works best even if it's slightly un-DRY as they are simple tests and provides a contained place if Claro and Olivero messages become less similar, or require additional theme-specific test coverage.

2. +++ b/core/tests/Drupal/Nightwatch/Tests/Claro/claroDrupalMessageTest.js
   @@ -22,20 +23,20 @@ const secondaryButtons = {
   +      .drupalInstallModule('nightwatch_theme_install_utility')
   

   Lets add this module to the nightwatch_testing profile instead of having to explicitly enable it here. Then it'll be available to any other nightwatch tests wanting to install a theme. I figured this should happen the first time we run into a new nightwatch test that benefits from it, and this is that test!

Addressed #9. 😇

Assigning credit from the previous issue.

Moving back to RTBC as patch 10 interdiff is tests-only and the tests passed.

Simple fix + some quality tests to confirm the efficacy. Thanks folks!

Committed to 11.x and cherry-picked to 10.1.x

Automatically closed - issue fixed for 2 weeks with no activity.