Care for unexposed keys in my_pattern.ui_patterns.yml

How about this simpler approach instead?

1 lvl less nesting! I think that's better.

We may take the chance and fix empty settings behavior for "Pattern settings" and "Context variables" as well?
These are not critical (do not throw exceptions) but you get empty, confusing 'details' containers in the settings form when nothing is provided.

Go for it!

This should do it

Thanks for working on this

1. +++ b/src/Plugin/Block/ComponentBlock.php
   @@ -277,56 +277,58 @@ class ComponentBlock extends BlockBase implements ContainerFactoryPluginInterfac
   +    if(isset($plugin['fields']) && !empty($plugin['fields'])) {
   

   !empty($plugin['fields']) should be enough here (don't need both empty and isset)

2. +++ b/src/Plugin/Block/ComponentBlock.php
   @@ -337,12 +339,14 @@ class ComponentBlock extends BlockBase implements ContainerFactoryPluginInterfac
   -      $form['settings'] = array_merge($form['settings'] ?? [], [
   -        '#type' => 'details',
   -        '#title' => $this->t('Pattern settings'),
   -        '#open' => TRUE,
   -        '#tree' => TRUE,
   -      ]);
   +      if(isset($form['settings'])) {
   +        $form['settings'] = array_merge($form['settings'], [
   +          '#type' => 'details',
   +          '#title' => $this->t('Pattern settings'),
   +          '#open' => TRUE,
   +          '#tree' => TRUE,
   +        ]);
   +      }
   

   I don't think we need this, we already had null coalesce here

Thanks for mentoring!

Never got familiar with patch-workflow. There's more to come in my contribution career, thus made myself familiar with Drupal PR workflow on drupalcode.org Lets continue there!

Here as patch again.

Oops.. i've ended with 2 issue branches and 2 merge request. Sorry for the noise. Just drop the wrong instance. Next time I'll do better.

TomSaw → closed merge request !10

@larowlan please have a look again. This MR should do it now!

Looks like tests are failing?

obviously I do not have enough comprehension how drupal and gitlab works.

Back to school for me then... I'll come back with a nice green MR.