- Issue created by @justcaldwell
- First commit to issue fork.
- 🇮🇳India Priya_Degwekar
Hi, I have created a patch according to the Proposed resolution.
Also attaching after patch results.
Please review and test the patch.
Thank you! - Status changed to Needs review
almost 2 years ago 7:11am 19 June 2023 - Status changed to RTBC
almost 2 years ago 4:46pm 21 June 2023 - 🇵🇭Philippines clarkssquared
Hi Priya_Degwekar
I applied your patch #4 to my local and I confirmed that gin and gin_toolbar dependencies were added successfully.
Please look at the screenshot attached for your reference.
Thank you
- Status changed to Needs work
over 1 year ago 8:53pm 2 August 2023 - 🇺🇸United States justcaldwell Austin, Texas
The current patch is just a copy-and-paste of the gin_toolbar code with no modification, other than the hook signature (e.g. it still refers to "Gin Toolbar").
On reflection, since Gin Toolbar establishes the Gin dependency, it should be enough to just add
gin_toolbar:gin_toolbarto the info.yml dependencies. IS updated accordingly. - Status changed to Needs review
over 1 year ago 11:58am 3 August 2023 - 🇧🇷Brazil elber Brazil
Hi I just added the dependency in .yml file please revise.
- @justcaldwell opened merge request.
-
justcaldwell →
committed 4715d629 on 1.0.x
Issue #3364539 by Priya_Degwekar, elber: Add gin and gin_toolbar...
-
justcaldwell →
committed 4715d629 on 1.0.x
- Status changed to Fixed
over 1 year ago 3:58pm 15 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.