Contrib.social

Viewing the book navigation block with preview link when all unpublished gives PHP error

Open on Drupal.org →
Created on 31 May 2023, over 2 years ago

Problem/Motivation

Encounting the following PHP error when using Book module, Content moderation, Workflow and Preview link when a anon user tries to access a preview link to a draft page, when all pages are unpublished.

Drupal 9.5.9, Preview link 8.x-1.7,

Steps to reproduce

- Install and enable Book, Content Moderation, Workflow and Preview link
- Set up a book and book content type
- Add Content moderation and workflow states to the book content type
- Create a book including child pages, but leave all the pages in draft
- On a child page, generate a preview link
- Open preview link in private browser as anon user

This gives error

Uncaught exception 'TypeError' with message 'Drupal\book\BookManager::bookTreeOutput(): Argument #1 ($tree) must be of type array, null given, called in /docroot/core/modules/book/src/Plugin/Block/BookNavigationBlock.php on line 174' in /docroot/core/modules/book/src/BookManager.php:593

I rounded it down to the method bookTreeCheckAccess in bookManager, which is stripping out all the book pages (which it should, as a user won't have access to them yet).

Proposed resolution

I'm not sure where the responsibility lies, given the above setup.
However the error is resolvable by wrapping $below = $this->bookManager->bookTreeOutput($data['below']); in BookNavigationBlock.php in an if empty condition, eg.

if (!empty($data['below'])) {
  $below = $this->bookManager->bookTreeOutput($data['below']);
   if (!empty($below)) {
      return $below;
   }
}
🐛 Bug report
Status

Active

Version

9.5

Component
Book  →

Last updated 26 days ago

Created by

🇬🇧United Kingdom andybroomfield

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024