Contrib.social

Viewing the book navigation block with preview link when all unpublished gives PHP error

Open on Drupal.org →
Created on 31 May 2023, almost 2 years ago
Updated 18 September 2024, 7 months ago

Problem/Motivation

Encounting the following PHP error when using Book module, Content moderation, Workflow and Preview link when a anon user tries to access a preview link to a draft page, when all pages are unpublished.

Drupal 9.5.9, Preview link 8.x-1.7,

Steps to reproduce

- Install and enable Book, Content Moderation, Workflow and Preview link
- Set up a book and book content type
- Add Content moderation and workflow states to the book content type
- Create a book including child pages, but leave all the pages in draft
- On a child page, generate a preview link
- Open preview link in private browser as anon user

This gives error

Uncaught exception 'TypeError' with message 'Drupal\book\BookManager::bookTreeOutput(): Argument #1 ($tree) must be of type array, null given, called in /docroot/core/modules/book/src/Plugin/Block/BookNavigationBlock.php on line 174' in /docroot/core/modules/book/src/BookManager.php:593

I rounded it down to the method bookTreeCheckAccess in bookManager, which is stripping out all the book pages (which it should, as a user won't have access to them yet).

Proposed resolution

I'm not sure where the responsibility lies, given the above setup.
However the error is resolvable by wrapping $below = $this->bookManager->bookTreeOutput($data['below']); in BookNavigationBlock.php in an if empty condition, eg.

if (!empty($data['below'])) {
  $below = $this->bookManager->bookTreeOutput($data['below']);
   if (!empty($below)) {
      return $below;
   }
}
🐛 Bug report
Status

Fixed

Version

2.0

Component
Book  →

Last updated about 2 months ago

Created by

🇬🇧United Kingdom andybroomfield

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @andybroomfield
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update almost 2 years ago
    30,334 pass, 2 fail
  • @andybroomfield opened merge request.
  • Comment almost 2 years ago →
    🇬🇧United Kingdom andybroomfield

    We're actually having a little trouble replicating this exactly.
    It does seem to happen, but the circumnstaces are weirdly specific. It's when one of the pages was previously published, then set back to draft with the latest revision, but the previous revision is left published. Then trying to use preview link on some (but not all) the child pages results in the error.
    I don't actully think Book is at fault here, it must be something to do with the way the preview link is interacting with workflow and content revisions, but will need more investigation. The patch fixes the error in that the navigation block can then display, though thats probably not the real problem.

  • Comment 12 months ago →
    🇳🇿New Zealand quietone
  • Status changed to Fixed 7 months ago
  • Comment 7 months ago →
    🇺🇸United States smustgrave

    Small enough change don't mind including with upcoming alpha release

  • Comment 7 months ago →
    System Message
    • smustgrave → committed 08df0f0a on 2.0.x 
      Issue #3363858 by andybroomfield: Viewing the book navigation block with...
  • Comment 7 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024