Database update errors when upgrading from 1.5 to 2.1 pluginid not found

It was a faulty record in tables group_content_field_data and group_content_field_data. Removing these entries makes updatedb fine.

So I think this could be closed

I'm facing the same problem.

[notice] Update started: group_update_9203
[error]  Call to a member function getPluginId() on null
[error]  Update failed: group_update_9203

Already spent half a day and a night to try different ways. Already having several thousand entries in the database. Couldn't find a way to filter out faulty ones.
Any ideas how to either:

• filter out and remove faulty entries?
• or change the update code in a way not ending up in a fatal error?

the actual code in group.install is:

function group_update_9203(&$sandbox) {
  $definition_update_manager = \Drupal::entityDefinitionUpdateManager();
  $last_installed_schema_repository = \Drupal::service('entity.last_installed_schema.repository');
  assert($last_installed_schema_repository instanceof EntityLastInstalledSchemaRepositoryInterface);

  // Update the database tables.
  $entity_type = $definition_update_manager->getEntityType('group_content');
  $entity_type->set('base_table', 'group_relationship');
  $entity_type->set('data_table', 'group_relationship_field_data');

  // Add the plugin_id and group_type field.
  $field_storage_definitions = $last_installed_schema_repository->getLastInstalledFieldStorageDefinitions('group_content');
  $field_storage_definitions['plugin_id'] = BaseFieldDefinition::create('string')
    ->setName('plugin_id')
    ->setTargetEntityTypeId('group_content')
    ->setTargetBundle(NULL)
    ->setLabel(t('Plugin ID'))
    ->setRequired(TRUE)
    ->setReadOnly(TRUE)
    ->setInitialValue('TEMP')
    ->setProvider('group');

  $field_storage_definitions['group_type'] = BaseFieldDefinition::create('entity_reference')
    ->setName('group_type')
    ->setTargetEntityTypeId('group_content')
    ->setTargetBundle(NULL)
    ->setLabel(t('Group type'))
    ->setSetting('target_type', 'group_type')
    ->setRequired(TRUE)
    ->setReadOnly(TRUE)
    ->setInitialValue('TEMP')
    ->setProvider('group');

  // Update the fields and regenerate indexes, the correct initial values will
  // be retrieved from GroupRelationshipStorage::restore().
  $definition_update_manager->updateFieldableEntityType($entity_type, $field_storage_definitions, $sandbox);
}

Hello @ViNCE,

I am facing an issue on the same hook. The error is "Langcode is missing". For me the field definition ($field_storage_definitions) is empty when I try to debug it in a preprocess. So obviously the Langcode field is missing for a translatable array.

I had tried to set these just before by using :

$storage_definitions = $entityFieldManager->getFieldStorageDefinitions('group_content');
$last_installed_schema_repository->setLastInstalledFieldStorageDefinitions('group_content',$storage_definitions);

And then it shows me other errors.
SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'entity_id' cannot be null: INSERT INTO "tmp_4e14aegroup_relationship_field_data"

it seems that it has loop over some database entries because there is some warning that are repeated before :

  [warning] Undefined array key "plugin_id" SqlContentEntityStorage.php:597
  [warning] Undefined array key "group_type" SqlContentEntityStorage.php:597

Il your storage definition empty ?
Does the hook seems to process some items and one is failing or it fails at the beginning ?

Hi,

I use res-ben code ✨ Entities identified by strings as group content Closed: won't fix to properly uninstall patch "2797793-279.patch".
This code populates 'entity_id' column during the process.

@aleix - I realize your comment at #3 is five months old, but do you recall how you identified the 'faulty records' in tables group_content_field_data and group_content that needed removing?

Cannot recall exactly, but looking the tables I think that it was some non existing entity somewhere indexed in this table, If you have not too much entries check these id's. Or better use dpm or xdebug breakpoint to check which id is failing...

Many thanks @aleix - it turned out we had left behind some rows in the group_content table that referenced items that were (at one point) found in the group_content__entity_id_str table to support the essentially defunct groupmenu module. We removed references to those items in both group_content_field_data and group_content tables and we stopped having this issue. (We have moved away from groupmenu and are adopting group_content_menu - but getting out from under the patch from https://www.drupal.org/project/group/issues/2797793 ✨ Entities identified by strings as group content Closed: won't fix was a bear.)

It turned out we also had left behind some rows in the following database tables

• group_content
• group_content_field_data

I ran some comparisons using the YML file to determine which rows I need to delete. The YML files for these content types have names like group.content_type.group_content_type_1123kl123lkzz.yml

If you have orphaned data you might find out which type or bundle rows need to be deleted based on the group content type config files you have.

Once you have determined the orphaned rows, you can run some database delete queries.

\Drupal::database()->delete('group_content')
    ->condition('type', 'group_content_type_1123kl123lkzz', '=')
    ->execute();

\Drupal::database()->delete('group_content_field_data')
    ->condition('type', 'group_content_type_1123kl123lkzz', '=')
    ->execute();