Conflict when upgrading webform module to be Drupal 10 compatible

Created on 26 May 2023, over 1 year ago
Updated 19 March 2024, 8 months ago

Problem/Motivation

In webform_simplify.info.yml the dependency is listed as follows:

dependencies:
  - webform:webform (>=6.1)

However, there is no Drupal 10 compatible webform version with this requirement.

This makes it hard to use this module with Drupal 10 which shouldn't because webform_simplify:1.1.0 is listed to be compatible with ^10

Steps to reproduce

  1. Update webform module to Drupal 10 compatible version
  2. get [error] Webform Simplify requires this module and version. Currently using Webform
    version
    (Currently using Unresolved dependency Webform (Version >=6.1 required)

I have tried using this module with webform 6.2.0-beta5 and no errors have yet been found.

Proposed resolution

see patch

Remaining tasks

  • running proper tests
💬 Support request
Status

Closed: outdated

Version

1.1

Component

Code

Created by

🇧🇪Belgium akasake

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @akasake
  • Issue was unassigned.
  • 🇧🇪Belgium dieterholvoet Brussels

    I added the specific webform requirement to make sure that we check if any render element keys as defined in the WebformSimplifyElement plugins changed in between versions. Ideally, before expanding the webform version requirement, we would add some integration tests that make sure that all keys returned in the getFeaturePropertyMap method (like e.g. properties.form.length_container.minlength) actually exist in the relevant webform render arrays.

  • First commit to issue fork.
  • @sakthi_dev opened merge request.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India sakthi_dev

    Please review.

  • Status changed to Needs work over 1 year ago
  • 🇧🇪Belgium dieterholvoet Brussels

    Like I said, we're going to need tests before widening the version constraint. Also, a patch was already attached with the exact same change. I'm removing credit for now.

  • Status changed to Closed: outdated 8 months ago
  • 🇧🇪Belgium dieterholvoet Brussels

    Feel free to re-open if I'm wrong, but I don't think this is an issue anymore. We're using this module om Drupal 10 and everything is working fine. I also don't see why we would need to drop Webform 6.1 support as long as we're supporting Drupal 9.

Production build 0.71.5 2024