- Issue created by @akasake
- Issue was unassigned.
- 🇧🇪Belgium dieterholvoet Brussels
I added the specific webform requirement to make sure that we check if any render element keys as defined in the
WebformSimplifyElement
plugins changed in between versions. Ideally, before expanding the webform version requirement, we would add some integration tests that make sure that all keys returned in thegetFeaturePropertyMap
method (like e.g.properties.form.length_container.minlength
) actually exist in the relevant webform render arrays. - First commit to issue fork.
- @sakthi_dev opened merge request.
- Status changed to Needs review
over 1 year ago 1:27pm 30 May 2023 - Status changed to Needs work
over 1 year ago 1:44pm 30 May 2023 - 🇧🇪Belgium dieterholvoet Brussels
Like I said, we're going to need tests before widening the version constraint. Also, a patch was already attached with the exact same change. I'm removing credit for now.
- Status changed to Closed: outdated
8 months ago 3:27pm 19 March 2024 - 🇧🇪Belgium dieterholvoet Brussels
Feel free to re-open if I'm wrong, but I don't think this is an issue anymore. We're using this module om Drupal 10 and everything is working fine. I also don't see why we would need to drop Webform 6.1 support as long as we're supporting Drupal 9.