The chosen default value of the role_id is not pre-selected in the field form

Thanks for the report @marco.aresu! @Grevil could you perhaps have a look and if it's not to complicated, write a test to proof and fix that?

PS: Perhaps this is a configuration issue if roles field is not set to unlimited but a single value?

Yes, the reason behind this is, as you correctly said, the single value option.

I don't really see a reason to NOT use cardinality unlimited ever. Should we simply not allow cardinality 1? Or is there only a hacky workaround to achieve this?

FYI: Not only is the standard value not not saved, but there is also an "N/A" entry for the checkboxes.

@Grevil: I don't think we can force this, so presumably we have to care for the case it's not unlimited and ensure it still works... might need a further if or so...

Fixed, please review!

Unfortunately, I couldn't fix the weird "N/A" bug when the field cardinality is set to 1. But I created a separate issue for that: 🐛 Field Cardinality set to "1" will add a "_none" role to the role id radios form element. Closed: works as designed .

Test run is buggy again

Thanks @Grevil!

@marco.aresu does this fix the issue for you?

@Grevil: Did you consider the case, where a fixed cardinality of 1-10 is used? The last comment added implies something different, so I'm asking. Having unlimed vs. something else is good, I think, but we have to care it doesn't only work for 1 or unlimited, but also 2,3,4,...

I won't set this RTBC without testing it throughoutly, seems to touch dangerous parts of the code. Let's wait for further community feedback.

Ah sorry, I have not, good call! The logic needs to be reworked.

OK, fixed now, please review once again.

Thanks, the problem is solved.

Back to the drawing board-

Added tests, but they still fail, as the current implementation is still buggy.

Done! We actually do not need to check the default Literal value. We just incorrectly received the "$items" values, thats all.

Added detailed tests and reworked the default value logic. Please review!

Note, that all Tests are green locally.

RTBC, thanks @Grevil. Composer still fails, but as of https://www.drupal.org/docs/develop/creating-modules/add-a-composerjson-... → the fix here should make it work for future MR's hopefully. Wondering, why it doesn't yet work here: https://git.drupalcode.org/project/entity_access_by_role_field/-/merge_r...

Automatically closed - issue fixed for 2 weeks with no activity.