- Issue created by @spokje
- Status changed to Needs review
over 1 year ago 8:05am 25 May 2023 - last update
over 1 year ago CI aborted - Status changed to Closed: outdated
over 1 year ago 8:47am 25 May 2023
Since
📌
Focus is lost on dialog close if the opener is inside a collapsible element
Fixed
there have been fairly frequent random fails in I\Drupal\Tests\contextual\FunctionalJavascript\ContextualLinksTest::testContextualLinksClick iin the daily and commit tests of 10.1.x and 11.x.
The full PHPUnit error from DrupalCI is:
Testing Drupal\Tests\contextual\FunctionalJavascript\ContextualLinksTest
.F.. 4 / 4 (100%)
Time: 00:53.068, Memory: 4.00 MB
There was 1 failure:
1) Drupal\Tests\contextual\FunctionalJavascript\ContextualLinksTest::testContextualLinksClick
JavaScript condition met:
document.activeElement === document.querySelector("#block-branding button.trigger")
Failed asserting that false is true.
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/var/www/html/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:166
/var/www/html/core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinksTest.php:97
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
