Header need style

Tanushree Gupta → made their first commit to this issue’s fork.

Hello @Tanushree Gupta,
I've reviewed your MR, though the MR seems to be good and after applying the patch the header style on active status is getting resolved and menu links are properly visible, but I don't think it still looks good. The background should cover the width of the menu items and not the full width, also on placing the site-branding block on the primary menu region things are getting broken, I things blocks in the regions should also be in flex, so as to make it appealing. On the other hand, I've identified that when I'm placing the site-branding block on the header region its not getting visible. So I think it'll be better if we target that as well over here, as we're talking about the whole header styling.
Attaching all the screenshots for reference, also the issue metadata seems to be wrong, hence updating that as well!

Here is the updated code for the header design.

I have changed the positions of the blocks through the block layout, as I thought it was necessary. I have attached a screenshot of the block layout.

Additionally, the header of the site was not visible, so I corrected the code for that part as well.

I also added the necessary CSS for desktop, tablet, and mobile views.
Here are the commits:
https://git.drupalcode.org/project/insha/-/merge_requests/19/commits

Hi, @Tanushree Gupta the patch is not getting applied now, throwing error. Please check!
These are the errors I'm currently getting while applying the patch:

Checking patch css/layout/layout.css...
error: while searching for:
  border: 1px solid #0fbe7c;
  text-decoration: none;
}

error: patch failed: css/layout/layout.css:1295
error: css/layout/layout.css: patch does not apply
Checking patch css/layout/layout.css...
Hunk #1 succeeded at 839 (offset -1 lines).
error: while searching for:

.search-block-form input {
  margin: 0;
  padding: 0.6em 1em;
  width: 100%;
}


error: patch failed: css/layout/layout.css:950
error: css/layout/layout.css: patch does not apply
Checking patch css/state/responsive.css...
Checking patch insha.libraries.yml...
Checking patch js/script.js...
Checking patch templates/page.html.twig...
headerfix.patch:344: new blank line at EOF.
+
Checking patch templates/region--primary-menu.html.twig...
Checking patch css/layout/layout.css...
error: while searching for:
  display: flex;
  justify-content: space-between;
  align-items: center;
  /* box-shadow: 0 0 60px 0 rgba(0,0,0,.1) */

}
.region-primary-menu {

error: patch failed: css/layout/layout.css:1268
error: css/layout/layout.css: patch does not apply
Checking patch templates/page.html.twig...

Raised an MR for 3.x-1.x. Needs Review.

Hi @Tanushree Gupta,
Thanks for the efforts! Though all the MR comments seems to be resolved well, but we're still unable to apply the patch properly. Encountering an error while applying the patch, and that might be due to some whitespace issue as it seems apparently.
Hence once again moving it to NW!

I applied the patch, and the changes are visible. However, there are some warnings. I tried to resolve them, but they are not appearing. I am sharing a screenshot for your reference. Apart from this, I believe the changes are visible, so you can review them.