- Issue created by @Shanu Chouhan
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:33pm 24 May 2023 - Status changed to RTBC
4 months ago 12:58pm 13 August 2024 - šµšPhilippines cleavinjosh
Hi @Shanu Chouhan,
I applied patch#2, it was applied smoothly and fixed the issues related to the README.md file.
ā contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml webform_inline_entity_form FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/webform_inline_entity_form/webform_inline_entity_form.info.yml ----------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------- 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/webform_inline_entity_form/src/Plugin/WebformElement/WebformInlineEntityForm.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 13 ERRORS AND 11 WARNINGS AFFECTING 23 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | WARNING | [x] Unused use statement 40 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 41 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 42 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 45 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 46 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 47 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 49 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 50 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 51 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 52 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6 102 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 169 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 172 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 173 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 175 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 179 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 182 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 183 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 194 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 201 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters 201 | ERROR | [x] 6 spaces found before inline comment; expected "// $form['entity_reference']['selection_settings']['target_bundles']['#type'] = 'select';" but found "// | | $form['entity_reference']['selection_settings']['target_bundles']['#type'] = 'select';" 207 | WARNING | [ ] There must be no blank line following an inline comment 222 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/webform_inline_entity_form/src/Element/WebformInlineEntityForm.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- Time: 130ms; Memory: 10MB ā contrib
I will now move the status to RTBC since this issue focuses on the issues regarding with lines exceeding 80 characters.
Thank you.