- Issue created by @urvashi_vora
- Assigned to PrabuEla
- Issue was unassigned.
- Assigned to Shanu Chouhan
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 5:46pm 24 May 2023 - Assigned to urvashi_vora
- Issue was unassigned.
- Status changed to RTBC
about 1 year ago 3:33am 25 May 2023 - 🇮🇳India urvashi_vora Madhya Pradesh, India
Reviewed the patch provided by @Shanu Chouhan. It applies cleanly and modifies the code appropriately.
I can confirm that no issues left for:
1. File::load calls should be avoided in classes, use dependency injection instead
2. \Drupal calls should be avoided in classes, use dependency injection insteadThanks for the work. Moving it to RTBC.
- Status changed to Needs review
about 1 year ago 6:29am 25 May 2023 Thank you for the patch. I have implemented the patch file to use dependency injection instead of classes and also fixed the following error on the new version
Argument #1 ($file_storage) must be of type Drupal\Core\Entity\EntityStorageInterface, array given- Assigned to sujan.shrestha
- Status changed to Fixed
about 1 year ago 7:57am 27 May 2023 - Status changed to Fixed
about 1 year ago 7:59am 27 May 2023