- Issue created by @wim leers
- 🇮🇳India omkar.podey
omkar.podey → made their first commit to this issue’s fork.
- last update
over 1 year ago 788 pass - @omkarpodey opened merge request.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Could we just add this to require-dev instead?
AFAICT that would re-introduce the very problem that 📌 Remove psr/http-message from drupal/core-recommended Fixed fixed? 🤔
- 🇬🇧United Kingdom catch
I think it could be in require-dev with a wide version range though?
- First commit to issue fork.
- last update
over 1 year ago 778 pass, 4 fail - last update
over 1 year ago Composer require-dev failure - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago Custom Commands Failed - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 778 pass, 4 fail - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Note that the failure on
10.0.x
is pre-existing — see https://www.drupal.org/pift-ci-job/2672722 → , it's been happening for almost 2 months:So queued a test against
10.1.x
. - last update
over 1 year ago 778 pass, 4 fail - last update
over 1 year ago 788 pass - 🇺🇸United States tedbow Ithaca, NY, USA
I think we should commit the last commit
\Drupal\Tests\package_manager\Build\TemplateProjectTestBase::createTestProject
with a follow-up to figure what the best solution is.It passes if we put
"composer-runtime-api": "^2.1",
intorequire
in composer.json because then will be present in the built project in the build test. But if we putrequire-dev
it will not be present. I have confirmed this locally. We don't want to have to our dev dependency in the built project in the build test because then we don't know if the build test will pass without them. - 🇺🇸United States tedbow Ithaca, NY, USA
follow-up 🐛 Build tests fail without explicitly requiring psr/http-message Closed: outdated
41:24 4:42 Running-
tedbow →
committed a25e47d0 on 3.0.x authored by
omkar.podey →
Issue #3362110 by tedbow, omkar.podey: Build tests failing in 10.1.x...
-
tedbow →
committed a25e47d0 on 3.0.x authored by
omkar.podey →
- Status changed to Fixed
over 1 year ago 4:17pm 23 May 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
It'd have been great if the newly added line actually linked to the follow-up issue. Also: might as well have kept this open? Less overhead.
There's less detail in 🐛 Build tests fail without explicitly requiring psr/http-message Closed: outdated than here … so, in the spirit of having actually useful issue summaries: closed 🐛 Build tests fail without explicitly requiring psr/http-message Closed: outdated in favor of reopening this.
- Status changed to Needs work
over 1 year ago 4:43pm 23 May 2023