- Issue created by @effulgentsia
- last update
over 1 year ago 29,388 pass - Status changed to RTBC
over 1 year ago 11:06pm 22 May 2023 - πΊπΈUnited States smustgrave
Timing couldn't be more perfect. Was updating to D10.1 and hit π Upgrade dependencies for Drupal 10.1 compatibility, use zipstream-php 3.0 Fixed
Going to mark as I assume tests will pass. (none have failed from. checking console output).
- π¬π§United Kingdom catch
Good plan. Committed/pushed to 11.x and 10.1x., thanks!
- Status changed to Fixed
over 1 year ago 8:41am 23 May 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This introduced test failures for build tests of https://www.drupal.org/project/automatic_updates β .
A freshly queued test run against
10.1.x
suddenly fails, with zero changes having been committed to that module since the last test run: https://www.drupal.org/pift-ci-job/2673631 β1) Drupal\Tests\automatic_updates\Build\CoreUpdateTest::testApi Failed asserting that 'Error: Interface "Psr\Http\Message\UriInterface" not found in include() (line 17 of /tmp/build_workspace_e1dc4f9c9db3e326a986c427d8d30cd1a0xXzJ/project/vendor/guzzlehttp/psr7/src/Uri.php).\n ' contains "Username:". /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122 /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55 /var/www/html/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php:292 /var/www/html/core/tests/Drupal/BuildTests/QuickStart/QuickStartTestBase.php:39 /var/www/html/modules/contrib/automatic_updates/package_manager/tests/src/Build/TemplateProjectTestBase.php:105 /var/www/html/modules/contrib/automatic_updates/package_manager/tests/src/Build/TemplateProjectTestBase.php:288 /var/www/html/modules/contrib/automatic_updates/tests/src/Build/UpdateTestBase.php:21 /var/www/html/modules/contrib/automatic_updates/tests/src/Build/CoreUpdateTest.php:71 /var/www/html/modules/contrib/automatic_updates/tests/src/Build/CoreUpdateTest.php:99 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684 /var/www/html/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651 /var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:144 /var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:97
which is triggered by
\Drupal\BuildTests\QuickStart\QuickStartTestBase::installQuickStart()
:public function installQuickStart($profile, $working_dir = NULL) { $php_finder = new PhpExecutableFinder(); $install_process = $this->executeCommand($php_finder->find() . ' ./core/scripts/drupal install ' . $profile, $working_dir); $this->assertCommandOutputContains('Username:'); β¦
But core's build tests are not failing! π€
I bet this is due to the special copying stuff with specific attention for vendor packages in
\Drupal\Tests\package_manager\Build\TemplateProjectTestBase::createTestProject()
β¦ maybe because it's now only an indirect dependency that test is now failing? π€Created π Since #3361983 was committed to Drupal core, psr/http-message needed to be explicitly required for build tests Needs work for investigating on the contrib module side.
- πΊπΈUnited States kevinquillen
This was committed, but I still get a test failure here:
https://www.drupal.org/pift-ci-job/2675934 β
Do I need to change anything? AFAIK this error stems from the original issue.
- πΊπΈUnited States effulgentsia
This issue is about drupal/core-recommended, whereas I think #10 is unrelated to drupal/core-recommended, but is a good question about DrupalCI. I opened #3362781: How to allow DrupalCI to downgrade packages from core's composer.lock versions when installing the contrib project under test? β for that.
Automatically closed - issue fixed for 2 weeks with no activity.