Google Analytics etc. double pageviews (through serviceworker calls)

FYI, the GA code was in the theme's js document ready function. I removed it and used the google_tag module. No more double pageviews.

I was able to create a regex in the cache url exclusion to stop the double pageviews

Thanks @mbenfield, could you perhaps share your solution with the community?

I guess this is by design and the way you're embedding the GA code. Don't see a general issue or something we could fix here, but leaving this open for others to have a look.

@mbenfield any update on #4?

Not sure if this is related... I just installed this module and noticed that gtag.js is being fetched twice now. In fact, all my external resources are being fetched twice. The initiator is service-worker-data.

I am using the googletag module with advagg.

Thanks, so we need to find out, if there's a general solution for this and if this is a general PWA problem or a problem of this module's implementation!

Found some related things, so this kind of a service worker issue, but we have to find a solution here in the module:

• https://stackoverflow.com/questions/54225136/excluding-analytics-js-and-...
• https://stackoverflow.com/questions/45663796/setting-service-worker-to-e...
• https://github.com/hanford/next-offline/issues/224

Of course we could start a blacklist, but that will be a never ending story.
So I think we should instead try to only load current URL sources by default? If anyone wants to change that, it's his job to do so.

But of course that approach might also not be that easy, for example if there are absolute URLs vs. relative etc.

If anyone needs a quick solution, add the external scripts to the service worker blacklist.

How to solve this best, @Grevil?

I'll take a look, after I resolved the other issues! 👍

Let's postpone this on 🐛 [META][pwa_service_worker] Refactor 'pwa_service_worker' implementations and flaws Needs work

Who runs into this should consider disabling the service worker for now.