- Issue created by @mglaman
- Assigned to samit.310@gmail.com
- Status changed to Needs work
over 1 year ago 2:14pm 16 June 2023 - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:06pm 16 June 2023 - Status changed to Needs work
over 1 year ago 4:28pm 16 June 2023 - 🇺🇸United States mglaman WI, USA
Needs work to fix missing space on
$token =$event->
-
+++ b/src/EventSubscriber/PasswordPolicyEventSubscriber.php @@ -106,7 +95,7 @@ class PasswordPolicyEventSubscriber implements EventSubscriberInterface { - $is_ajax = $this->request->headers->get('X_REQUESTED_WITH') === 'XMLHttpRequest'; + $is_ajax = $event->getRequest()->headers->get('X_REQUESTED_WITH') === 'XMLHttpRequest';
The request method provides
isXmlHttpRequest
which could replace this check. That change may be considered out of scope, though. -
+++ b/src/EventSubscriber/PasswordPolicyEventSubscriber.php @@ -126,8 +115,8 @@ class PasswordPolicyEventSubscriber implements EventSubscriberInterface { + $token =$event->getRequest()->query->get('pass-reset-token');
nit: missing space after
=
-
- Status changed to Needs review
over 1 year ago 4:41pm 16 June 2023 - 🇮🇳India samit.310@gmail.com
HI @mglaman,
Changes you suggest has been done, Please review.
Thanks
Samit K. - Status changed to RTBC
over 1 year ago 4:55pm 16 June 2023 - Assigned to Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Assigning to myself as I'm reviewing/merging ready RTBC fixes/updates over the next few days.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks for the work on this. I reviewed the code and tested various things with 10.1.8, and it worked as expected.
I wouldn't call this a bug though, so moving to task.
-
Kristen Pol →
committed f2f9c8da on 4.0.x authored by
samit.310@gmail.com →
Issue #3361638 by samit.310@gmail.com, mglaman, Kristen Pol: Fix usage...
-
Kristen Pol →
committed f2f9c8da on 4.0.x authored by
samit.310@gmail.com →
- Issue was unassigned.
- Status changed to Fixed
10 months ago 7:04pm 8 February 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
The fix has been merged and will be part of the next release.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
This is part of the new 4.0.1 release → .