- Issue created by @ericgsmith
- First commit to issue fork.
- Merge request !11831Resolve #3361361 "file_get_file_references does not return correct results when using $field param" β (Open) created by mxr576
- ππΊHungary mxr576 Hungary
I have also bumped into this issue recently and after some forensic analyses my gut says that the $field based filtering was never worked as expected in 8.x.
Back to the history:
* https://github.com/drupal/core/commit/8aa449c8248e87e3f675503be1da462c8c... - nothing to see here, just use DI
* https://github.com/drupal/core/commit/de8bb2efaa607caf1d913288ca160f64c4... - Maybe this is where it all got broken, or even before...?And we also have this CR related to the last commit: https://www.drupal.org/node/2260037 β
I have proposed a fix for it, I am uncertain at this point if this should be dropped or not, but should be fixed before # π [PP-1] Deprecate file_get_file_references(). Move the logic to file.usage service Postponed if it stays.
- ππΊHungary mxr576 Hungary
Functional JS tests fail for no valid reason on the CI, so that can be ignored.
- πΊπΈUnited States smustgrave
Havenβt reviewed but this needs steps. Just saying see patch doesnβt count :)
- ππΊHungary mxr576 Hungary
Yeah, well, that is part of the original description which I haven't changed, I have only fixed some typos and links.
That said, it is also true, since unless something changed in contrib since the issue was opened, the only code that calls the function and uses the $field parameter is in the test that proves that issue exists.
have search in contrib and was unable to find any attempt to use a non NULL value for this param.