form--search-block-form.html.twig uses 'form-row', but that class has been removed from bootstrap

Created on 17 May 2023, about 1 year ago

Updated 1 July 2023, 12 months ago

Problem/Motivation

The template form--search-block-form.html.twig still uses the class form-row, but the class was removed in Bootstrap 5 https://getbootstrap.com/docs/5.0/migration/#forms

After updating Bootstrap Barrio and Bootstrap I noticed the search block looked different. When I compared my local to production, I saw that flex was no longer applied.

I have not seen the issue reported, even though I thought it would impact other sites, so I am wondering if I am the one who's missing something.

Steps to reproduce

Update Bootstrap Barrio and Bootstrap from 4 to 5.
Inspect the search block

Proposed resolution

Update the template to use utility classes

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Closed: won't fix

Version

5.5

Component

Code

Created by

RedNeko

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @RedNeko
Comment about 1 year ago →
lukasz.tyc
lukasz.tyc → made their first commit to this issue’s fork.
Open on Drupal.org →
Core: 10.1.0-alpha1 + Environment: PHP 7.4 & MySQL 5.7
last update about 1 year ago
Waiting for branch to pass
@lukasztyc opened merge request.
Status changed to Closed: won't fix 12 months ago11:27pm 1 July 2023
Comment 12 months ago →
🇵🇪Peru hatuhay Lima
True the form-row was removed for B5 and should be removed on the Barrio B5 version, but is was not.
That class is harmless, but it is present on thousends of sites so I prefer not to delet it at this point.
Comment 9 months ago →
System Message
hatuhay → closed merge request !54

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024