Contrib.social

TypedData instances created by TypedConfigManager::createFromNameAndData() are incomplete

Open on Drupal.org →
Created on 17 May 2023, about 1 year ago
Updated 25 May 2023, about 1 year ago

Problem/Motivation

#2869809: Make it easy to get typed config representations of entities → introduced \Drupal\Core\Config\TypedConfigManager::createFromNameAndData():

  public function createFromNameAndData($config_name, array $config_data) {
    $definition = $this->getDefinition($config_name);
    $data_definition = $this->buildDataDefinition($definition, $config_data);
    return $this->create($data_definition, $config_data);
  }

It's great! It's used in many places.

But it has one bug: the \Drupal\Core\TypedData\TraversableTypedDataInterface instances it returns do not have a working getName() nor a working getPropertyPath(), because we forgot to pass the third argument to ::create(): public function create(DataDefinitionInterface $definition, $value = NULL, $name = NULL, $parent = NULL) { — the $name!

Steps to reproduce

N/A — discovered in ✨ Expose validation constraints (and validatability %) in Config Inspector UI Fixed .

Proposed resolution

Specify $name.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

🐛 Bug report
Status

Fixed

Version

10.1 ✨

Component
Configuration  →

Last updated about 8 hours ago

Created by

🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024