TypedData instances created by TypedConfigManager::createFromNameAndData() are incomplete

@borisson_ raised a legitimate concern in Drupal Slack:

hm, it's kind of worrying that this has been in core for years and has only surfaced now, would it be an idea to be more defensive in the create method so that we alert people who are creating these objects when they are incomplete?

It’s been in core for years but that method is called virtually nowhere. It pretty much only exists in Typed Config tests!

Since CKEditor 5 is in core, 3 calls to it were added to core. Which brings it to a grand total of 12 🤣

The thing is that the commit that introduced it ( #2869809: Make it easy to get typed config representations of entities → ) was specifically done as one of the blockers for POST and PATCH support for config entities via the REST module.

But of course the validation pieces never materialized … so none of that really happened.

That’s why I’m running into it now: because I’m working on validation 🤓

Discussed with Wim in slack, I now understand why this only breaks in this scenario, patch looks great!

The last submitted patch, 2: 3360991-2-test-only-FAIL.patch, failed testing. View results →

Discovered this in ✨ Expose validation constraints (and validatability %) in Config Inspector UI Fixed and hence had to work around this.

Committed 96e2fd9 and pushed to 11.x. Also cherry-picked to 10.1.x. Thanks!

Interestingly, yesterday I was debugging code in 📌 Save FieldStorageConfig at the same time as FieldConfig Fixed where I had done the same mistake 😅 It did take me a while to realize until I found yet another map in \Drupal\Core\TypedData\TypedDataManager::$prototypes.

Automatically closed - issue fixed for 2 weeks with no activity.