- Issue created by @very_random_man
- Assigned to Grimreaper
- π«π·France Grimreaper France π«π·
Discussed with @Christian.wiedemann,
The toastify module adds toastify everywhere why it is only desired in Layout Builder.
Toastify is prefered to standard Drupal message to have something static and removeable. But we need to ensure that it is an optional feature.
I will check that.
- π©πͺGermany Christian.wiedemann
Grimreaper β credited Christian.wiedemann β .
- π«π·France Grimreaper France π«π·
The "custom" option in "Load Toastify" select in config form should be renamed into "Do not use" or something like that because in this case, Toastify is not loaded.
The problem is that standard messages does not appear anymore.
Also the README.md needs to be updated.
- @grimreaper opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:30pm 25 September 2023 - π«π·France Grimreaper France π«π·
No more JS error.
Better config option label.
Start to split JS.But the problem is that, due to template suggestions, even without Toastify, it does not take front theme messages theming into account. But I guess this would require a way more deeper refactoring, if possible...
If ok for you, I can merge.
- Status changed to RTBC
over 1 year ago 7:19am 26 September 2023 - π©πͺGermany Christian.wiedemann
Totaly fine with the implementation. It can be merged.
-
Grimreaper β
committed 3c9e1b54 on 1.0.x
Issue #3360930 by Grimreaper, very_random_man, Christian.wiedemann: Make...
-
Grimreaper β
committed 3c9e1b54 on 1.0.x
- Status changed to Fixed
over 1 year ago 8:25am 26 September 2023 - π«π·France Grimreaper France π«π·
Thanks for the quick feedback
Merged.
I think we are ok for a new release. :)
Automatically closed - issue fixed for 2 weeks with no activity.