Add custom block dialog won't disable

Created on 17 May 2023, over 1 year ago
Updated 25 April 2024, 7 months ago

Problem/Motivation

First let me thank you for the nice module!
I noticed the Add custom block dialog (first one) is always showing as off-canvas, even if I set it to Modal or I disable the administrative dialog, both when the task link is pressed from the Place block dialog and from the custom block library.

Steps to reproduce

Clean install on D10 + this module

🐛 Bug report
Status

Fixed

Version

1.0

Component

Miscellaneous

Created by

🇮🇹Italy kopeboy Milan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @kopeboy
  • 🇺🇸United States minnur San Francisco

    @kopeboy you probably also need to disable /block/add path from the Paths config. See /admin/config/user-interface/dialogs/manage/administrative/dialogs on your local setup.

  • 🇮🇹Italy kopeboy Milan

    This wouldn't be worth a bug report if the off-canvas styling wasn't completely different from the modals and the admin theme (Claro is the default) in general.

  • 🇺🇸United States minnur San Francisco

    I know, the styling should be handled in the theme. Many themes don't handle modals and off-canvas well. Lets hope this module will help to improve that.

  • 🇮🇹Italy kopeboy Milan

    Files an issue in core, feel free to join :) https://www.drupal.org/project/drupal/issues/3360933 🐛 Claro off-canvas dialog styling issues and inconsistencies Needs work

  • 🇮🇹Italy kopeboy Milan

    #2: I had already disabled the path and cleared the caches (with Devel link), but the link still opens the off-canvas dialog

    Also note that the checkbox to disable has not text (accessibility issue).

  • 🇺🇸United States crutch

    D9.5.9
    Claro Admin Theme
    Admin Dialogs
    + other modules

    1. Completed #2, Add Custom Block always shows in off-canvas format for any setting. This is not really an issue for us though.
    2. Deleted Add Custom Block to see if by chance it effects the first one in the list and it doesn't.
    --
    I found this module in the Drupal Newsletter. Thank you!

  • 🇺🇸United States minnur San Francisco

    Ok, I think I figured this out. The status checkbox works as expected.
    Also custom blocks controlled in two dialog configs:
    1. Add Custom Block - see block_content_add_action
    2. Paths - see */block/add*

    I wasn't sure if I should be clearing Drupal cache when making dialog changes so I put a little note at the top of the Admin Dialogs listing page.

    After making changes you need to clear Drupal cache.

  • Status changed to Needs review 9 months ago
  • 🇺🇸United States minnur San Francisco
  • Status changed to Fixed 7 months ago
  • 🇺🇸United States minnur San Francisco
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024