- Issue created by @dieterholvoet
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & sqlite-3.27last update
over 1 year ago Not currently mergeable. - @dieterholvoet opened merge request.
- Status changed to Needs review
over 1 year ago 11:22am 15 May 2023 - last update
over 1 year ago 86 pass - Status changed to RTBC
over 1 year ago 7:34am 23 May 2023 - 🇮🇳India kevinsiji
The patch works. Perfectly added links of ECK Entity types and bundles to the admin menu.
- 🇧🇪Belgium dieterholvoet Brussels
I changed the target branch of the MR to 2.x-dev and rebased onto the latest commit.
If some of the links are not showing make sure to check your Admin Toolbar "menu depth" settings at "admin/config/user-interface/admin-toolbar". You may need to increase depth settings.
I've also attached my own patch based on @DieterHolvoet's work. It adds a top level "Entity (ECK)" menu to the Admin toolbar, with direct links to "Add Content" for each entity, and faster links to "Manage" the entity fields and display.
- Status changed to Needs work
about 1 year ago 7:07pm 2 November 2023 - 🇨🇦Canada RobLoach Earth
@moser I'm not sure how I feel about adding a top-level admin link:
+ // Admin > ECK Link (type list) + $this->derivatives['system.admin.eck'] = [ + 'title' => 'Entity (ECK)', + 'route_name' => 'eck.entity_type.list', + 'parent' => 'system.admin', + 'weight' => -8, + 'id' => 'system.admin.eck', + ] + $base_plugin_definition;
I may be understanding this though. Having ECK appear beside Content and Structure seems weird.
- Status changed to RTBC
about 1 year ago 7:22pm 2 November 2023 - 🇧🇪Belgium dieterholvoet Brussels
I agree, we shouldn't add a new top-level link. The Content link is there for a reason. That change was posted as a separate patch though, nothing changed in the MR, so setting back to Reviewed & tested by the community.
-
RobLoach →
committed 6cca8587 on 2.x authored by
DieterHolvoet →
Issue #3360396: Add more menu links
-
RobLoach →
committed 6cca8587 on 2.x authored by
DieterHolvoet →
- Status changed to Fixed
about 1 year ago 7:43pm 2 November 2023 - 🇨🇦Canada RobLoach Earth
Thanks a lot, @DieterHolvoet! I agree. Tested locally and things were looking solid.
@moser If you're looking to add more to this, feel free to create a new Merge Request in a new issue. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.