- Issue created by @nicolasgraph
- First commit to issue fork.
Here's a patch to add the "EntityPublishedInterface" interface to the "Review" entity of the module.
- Status changed to Needs review
about 1 year ago 8:09am 4 September 2023 - Status changed to Needs work
about 1 year ago 9:03am 4 September 2023 - 🇫🇷France nicolasgraph Strasbourg
Thanks @MartinPJB, could you limit changes to what must be done to implement the trait please or explain why you changed some of the "status" field settings? I guess we should also deprecate
isEnabled()
in favour of theisPublished()
trait method. @NicolasGraph here's an updated version of my patch that uses
isPublished()
instead ofisEnabled()
. I also reverted the changes I made for some of the "status" field settings.Forgot to remove some calls to "isEnabled", I'm sorry. Here's a new patch
I've updated the patch so that it works with all the module's php unit tests.
All tests ran successfully with my updated patch, and the module also seems to work perfectly with Guest Suits activated.I kept the lines:
->setLabel(t('Status'))
and->setDefaultValue(TRUE)
as they cause an error in the unit tests when removed (Even though it doesn't seem to cause any trouble when browsing or using the module through Drupal's web interface).Everything seems to be fine now, I also made sure to deprecate
isEnabled()
in favour ofisPublished()
, but tell me if I forgot to change small details.I've removed the line duplication in
src/Entity/Review.php
(line. 336) as can be seen on this commit: https://git.drupalcode.org/issue/guest_suite-3360241/-/commit/c8875c2213...- @martinpjb opened merge request.
I've also made a merge request, I am going to put this on "need review", if you validate it then you can merge as well.
- Status changed to Needs review
about 1 year ago 9:16am 16 October 2023 - Status changed to Needs work
about 1 year ago 8:52pm 20 October 2023 - 🇫🇷France nicolasgraph Strasbourg
Thanks for your work @MartinPJB, could you just remove the .patch file from your changes please before we go forward please?
- Status changed to Needs review
about 1 year ago 10:15am 2 November 2023 -
NicolasGraph →
committed db11ffdf on 1.x authored by
MartinPJB →
Issue #3360241: Implements the EntityPublishedInterface
-
NicolasGraph →
committed db11ffdf on 1.x authored by
MartinPJB →
- Status changed to Fixed
about 1 year ago 4:33pm 2 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.