- Issue created by @DamienMcKenna
- πΊπΈUnited States DamienMcKenna NH, USA
I think the problem is that the plugin definition in pagebreak.ckeditor5.yml needs to specify which HTML elements it uses, so those HTML structures can be automatically added to the "Allowed HTML tags" list.
- πΊπΈUnited States DamienMcKenna NH, USA
I tried updating the pagebreak.ckeditor5.yml file with this:
elements: - '<div>' - '<div class="page-break" style="page-break-after:always;">' - '<span>' - '<span style="display:none;">'
However, when I hit "save" it then gave this error:
The current CKEditor 5 build requires the following elements and attributes:
- πΊπΈUnited States DamienMcKenna NH, USA
So how do we modify the Pagebreak plugin so it works as expected?
- πΊπΈUnited States DamienMcKenna NH, USA
Here are the ckedito5.yml line changes.
- Status changed to Needs work
over 1 year ago 11:50am 15 May 2023 - πΊπΈUnited States jrockowitz Brooklyn, NY
I am moving this to critical because the module does not work as expected via 3.x. and Drupal 10.
I am stumped on how to fix this. I suspect the
<span>
span tag will need an additional plugin. - πΊπΈUnited States DamienMcKenna NH, USA
The problem is the "style" attribute, that doesn't work well with ckeditor 5.
It's annoying that the "style" attribute is specifically noted by core to be unsafe, which is why it's filtered out by the "Limit allowed HTML tags and correct faulty HTML" filter, but this plugin uses it.
I opened an issue in the ckeditor issue queue, will see what the community says: https://github.com/ckeditor/ckeditor5/issues/15651
- πΊπΈUnited States DamienMcKenna NH, USA
I wonder if this module should require the extended_html_filter module instead of core's HTML filter?
- πΊπΈUnited States DamienMcKenna NH, USA
FWIW wrapping the 'style' item in ckeditor5.yml with quotes like this does not solve the problem:
elements: - '<* style>'
- πΊπΈUnited States DamienMcKenna NH, USA
I think this should be rewritten to use the pagebreak code provided by the CKEditor 5 Plugin Pack module β .
- Status changed to Closed: won't fix
6 months ago 11:34am 22 June 2024 - πΊπΈUnited States DamienMcKenna NH, USA
Skipping this in favor of the Plugin Pack module.