- Issue created by @ricovandevin
- @ricovandevin opened merge request.
- Status changed to Needs review
over 1 year ago 12:02pm 13 May 2023 - Status changed to Needs work
over 1 year ago 10:09pm 12 June 2023 - 🇳🇿New Zealand Gold 20 minutes in the future
Looking good, just one small tweak from what I'm seeing.
Commented on the fork.
https://git.drupalcode.org/issue/jsonapi_page_limit-3360180/-/commit/2d3...
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 5:25pm 24 June 2023 - 🇮🇳India bharath-kondeti Hyderabad
Updated the PR addressing #4. Please review
- 🇮🇳India dineshkumarbollu
Hi
I reviewed the MR it as still one D10 compatible error
vendor/bin/drush upgrade_status:analyze jsonapi_page_limit
[notice] Processing /var/www/html/vb9/web/modules/contrib/jsonapi_page_limit-3360180.================================================================================
JSON:API Page Limit, --
Scanned on Mon, 06/26/2023 - 14:01FILE:
web/modules/contrib/jsonapi_page_limit-3360180/src/Controller/EntityResource.phpSTATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 22 Class Drupal\jsonapi_page_limit\Controller\EntityResource
extends @internal class
Drupal\jsonapi\Controller\EntityResource. - 🇬🇧United Kingdom Eli-T Manchester
@dineshkumarbollu whilst use of @internal classes is flagged by upgrade status, they aren't necessarily a blocker to Drupal 10 compatibility.
See #3304053-7: Automated Drupal 10 compatibility fixes → for similar discussion and linked to further details in Slack.
Unfortunately because JSON:API proudly does not expose an API (because "HTTP is the API"), this kind of mechanism is kind of inevitable.
- Status changed to Needs work
over 1 year ago 5:16pm 12 July 2023 - last update
over 1 year ago 4 pass - last update
over 1 year ago 4 pass -
Eli-T →
committed 669ed1aa on 8.x-1.x authored by
ricovandevin →
Issue #3360180 by ricovandevin, Eli-T, Gold: Drupal 10 compatibility
-
Eli-T →
committed 669ed1aa on 8.x-1.x authored by
ricovandevin →
- Status changed to Fixed
over 1 year ago 11:02pm 13 July 2023 - Status changed to Needs work
over 1 year ago 11:09pm 13 July 2023 - 🇬🇧United Kingdom Eli-T Manchester
Let's drop support for Drupal 8 whilst we're here.
- Status changed to Fixed
over 1 year ago 11:10pm 13 July 2023 - 🇬🇧United Kingdom Eli-T Manchester
Actually that should be a separate issue now this one is included in a release.
Automatically closed - issue fixed for 2 weeks with no activity.